1719850 - Enforce no-unused-vars for global variables in marionette eslint configuration

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, task)

Description

[Julian Descottes [:jdescottes]]

no-unused-vars is not enforced for global variables on JS files, only on JSM files. See https://searchfox.org/mozilla-central/rev/183b0cfc30f2d40f818a08cbea960f6119e2d196/tools/lint/eslint/eslint-plugin-mozilla/lib/configs/recommended.js#60-75

However in remote/marionette, js files are really used as JavaScript modules and we should be able to enforce stricter linting rules.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1719850 - [marionette] Enforce no-unused-vars for global variables in marionette eslint configuration

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/845cb9274110
[marionette] Enforce no-unused-vars for global variables in marionette eslint configuration r=webdriver-reviewers,whimboo

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/845cb9274110

Comment 4

[Julian Descottes [:jdescottes]]

Quickly looked at the regressions listed here: all TV runs which failed were with Fission enabled, but RemoteAgent/cdp is not fission compatible (https://searchfox.org/mozilla-central/rev/5227b2bd674d49c0eba365a709d3fb341534f361/taskcluster/ci/test/mochitest.yml#815-816).

So those tests already fail without the patch which landed here, it's just that they never run with Fission enabled outside of the Test Verify configuration. And to be clear, they do not even need to run with --verify to fail. Simply running those tests once with --enable-fission is enough to make them all fail.

Comment 5

[Julian Descottes [:jdescottes]]

:nataliaCs : Hi! As mentioned in the comment above, all the TV regressions which have been flagged on this bug are existing failures. mochitest-remote jobs are not supposed to run on Fission environments until Bug 1600054 is fixed. Those tests are expected to fail with Fission. We can keep the bugs if needed, but do you mind if we remove the regression keyword from them, since they are really unrelated to the code change which landed here?

Comment 6

[Natalia Csoregi [:nataliaCs]]

(In reply to Julian Descottes [:jdescottes] from comment #5)

:nataliaCs : Hi! As mentioned in the comment above, all the TV regressions which have been flagged on this bug are existing failures. mochitest-remote jobs are not supposed to run on Fission environments until Bug 1600054 is fixed. Those tests are expected to fail with Fission. We can keep the bugs if needed, but do you mind if we remove the regression keyword from them, since they are really unrelated to the code change which landed here?

Fixing, thank you!

Comment 7

[Julian Descottes [:jdescottes]]

Thanks for updating all the bugs!