1719851 - Allow default-branch regional pref values in DoH Config

Status: RESOLVED FIXED

(Firefox :: Security, defect, P1)

Description

[(inactive) Nihanth Subramanya [:nhnt11]]

[Tracking Requested - why for this release]:

At some point during review, we ended up replacing an undefined check with Services.prefs.prefHasUserValue, which looks nicer but has the consequence of not considering values on the default pref branch.

Normandy rollouts always operate on the default branch, which means this doesn't work.

This does not affect the upcoming 1% rollout delivery because it is framed as an experiment, and we can use user-branch prefs there. But we need to fix this in 91.

Comment 1

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bug 1719851 - Allow default-branch regional pref values in DoH Config. r=Gijs!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f48ecbfdd4ca
Allow default-branch regional pref values in DoH Config. r=Gijs

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/f48ecbfdd4ca

Comment 4

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 9230470 [details]
Bug 1719851 - Allow default-branch regional pref values in DoH Config. r=Gijs!

Beta/Release Uplift Approval Request

• User impact if declined: This uplift is in support of unblocking our rollout of DoH in Canada. The patches for which uplift is being requested update the DoH settings UI to work better with Remote Settings, and simplify the Normandy recipe for the rollout.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1713036, Bug 1720379, Bug 1718097, Bug 1719851, Bug 1714486
• Risk to taking this patch: Medium
• Why is the change risky/not risky? (and alternatives if risky): The changes have been baking for a while and work well. Medium risk because of the number of patches we need to uplift.
• String changes made/needed:

Comment 5

[Carmen Fat [:cfat] - Ecosystem QA]

• We verified this issue across platforms (Windows 10 x64, Ubuntu 20 x64, macOS 11.4) using the 90.0.2 try-build provided by Nihanth.
• We performed smoke testing using the Remote Settings Stage environment on the DoH Preferences UI and didn't encounter any issues.
• The updated recipe set the doh-rollout.ca.enabled pref as a Default type on both treatment and control branches.

Comment 6

[Julien Cristau [:jcristau]]

Comment on attachment 9230470 [details]
Bug 1719851 - Allow default-branch regional pref values in DoH Config. r=Gijs!

approved for 90.0.2

Comment 7

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-release/rev/c24710e81b11