1719939 - Remove last fragments of code manually checking the browser.proton.enabled pref

Status: RESOLVED FIXED

(Firefox :: General, task)

Description

[:Gijs (he/him)]

https://searchfox.org/mozilla-central/search?q=browser.proton.ena&path=&case=false&regexp=false

Some of these have a little bit of associated cleanup to do, but none of them should be horrible to tidy up at this point.

Once bug 1719938 is done, we can also remove the actual pref from staticprefs.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Theme' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Junjie Ying]

Attachment: Bug 1719939 - Remove last fragments of code manually checking the browser.proton.enabled pref. r=mhowell,mtigley

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ea1653e9644f
Remove last fragments of code manually checking the browser.proton.enabled pref. r=mhowell

Comment 4

[Natalia Csoregi [:nataliaCs]]

Backed for causing bustage on media_features.rs

• backout: https://hg.mozilla.org/integration/autoland/rev/a74710133cf4409f2695c400e44943383eee5062

• push: https://treeherder.mozilla.org/jobs?repo=autoland&revision=ea1653e9644fc44669d0655b1bb6ab4800d2eb8e

• failure log: https://treeherder.mozilla.org/logviewer?job_id=352174691&repo=autoland&lineNumber=39386

[task 2021-09-21T00:29:17.502Z] 00:29:17     INFO -  error: no rules expected the token `"browser.proton.enabled"`
[task 2021-09-21T00:29:17.502Z] 00:29:17     INFO -     --> servo/components/style/gecko/media_features.rs:929:46
[task 2021-09-21T00:29:17.502Z] 00:29:17     INFO -      |
[task 2021-09-21T00:29:17.502Z] 00:29:17     INFO -  929 |     bool_pref_feature!(atom!("-moz-proton"), "browser.proton.enabled"),
[task 2021-09-21T00:29:17.502Z] 00:29:17     INFO -      |                                              ^^^^^^^^^^^^^^^^^^^^^^^^ no rules expected this token in macro call
[task 2021-09-21T00:29:17.502Z] 00:29:17     INFO -  warning: ignoring -C extra-filename flag due to -o flag
[task 2021-09-21T00:29:17.502Z] 00:29:17     INFO -  warning: `style` (lib) generated 1 warning
[task 2021-09-21T00:29:17.502Z] 00:29:17     INFO -  error: could not compile `style` due to previous error; 1 warning emitted
[task 2021-09-21T00:29:17.503Z] 00:29:17     INFO -  Caused by:
[task 2021-09-21T00:29:17.510Z] 00:29:17     INFO -    process didn't exit successfully: `CARGO=/builds/worker/fetches/rustc/bin/cargo CARGO_CRATE_NAME=style CARGO_MANIFEST_DIR=/builds/worker/checkouts/gecko/servo/components/style CARGO_PKG_AUTHORS='The Servo Project Developers' CARGO_PKG_DESCRIPTION='' CARGO_PKG_HOMEPAGE='' CARGO_PKG_LICENSE=MPL-2.0 CARGO_PKG_LICENSE_FILE='' CARGO_PKG_NAME=style CARGO_PKG_REPOSITORY='' CARGO_PKG_VERSION=0.0.1 CARGO_PKG_VERSION_MAJOR=0 CARGO_PKG_VERSION_MINOR=0 CARGO_PKG_VERSION_PATCH=1 CARGO_PKG_VERSION_PRE='' LD_LIBRARY_PATH='/builds/worker/workspace/obj-build/release/deps:/builds/worker/fetches/rustc/lib' OUT_DIR=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/release/build/style-a7faabc9dc359900/out /builds/worker/fetches/sccache/sccache /builds/worker/fetches/rustc/bin/rustc --crate-name style --edition=2018 servo/components/style/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts --crate-type lib --emit=dep-info,metadata,link -C opt-level=2 -C panic=abort -C embed-bitcode=no --cfg 'feature="bindgen"' --cfg 'feature="gecko"' --cfg 'feature="nsstring"' --cfg 'feature="regex"' --cfg 'feature="serde"' --cfg 'feature="toml"' -C metadata=6e054f7866942e33 -C extra-filename=-6e054f7866942e33 --out-dir /builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/release/deps --target x86_64-unknown-linux-gnu -C linker=/builds/worker/checkouts/gecko/build/cargo-linker -L dependency=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/release/deps -L dependency=/builds/worker/workspace/obj-build/release/deps --extern 'noprelude:alloc=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/release/deps/liballoc-a5dfd69446d7c8de.rmeta' --extern app_units=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/release/deps/libapp_units-6965c03eb89af0a8.rmeta --extern arrayvec=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/release/deps/libarrayvec-b290d2eafe2ed26d.rmeta --extern atomic_refcell=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/release/deps/libatomic_refcell-716852cb60b6047d.rmeta --extern bitflags=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/release/deps/libbitflags-8e775477d4184e84.rmeta --extern byteorder=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/release/deps/libbyteorder-ab903bef645b3d0b.rmeta --extern 'noprelude:compiler_builtins=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/release/deps/libcompiler_builtins-d1ef7f7983925a34.rmeta' --extern 'noprelude:core=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/release/deps/libcore-bef240d1aa277875.rmeta' --extern cssparser=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/release/deps/libcssparser-4269db6421deb0b7.rmeta --extern derive_more=/builds/worker/workspace/obj-build/release/deps/libderive_more-514fc11fa5d6fccc.so --extern euclid=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/release/deps/libeuclid-581dc393ac1c2947.rmeta --extern fallible=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/release/deps/libfallible-4e414697ea9f0c36.rmeta --extern fxhash=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/release/deps/libfxhash-64a7861891fd7259.rmeta --extern gecko_profiler=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/release/deps/libgecko_profiler-48ec0ee524db8f71.rmeta --extern hashbrown=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/release/deps/libhashbrown-3d6191217c5f2410.rmeta --extern hashglobe=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/release/deps/libhashglobe-3faef51e491873f9.rmeta --extern indexmap=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/release/deps/libindexmap-5b1276b66d31224f.rmeta --extern itertools=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/release/deps/libitertools-2ab92d851f39d829.rmeta --extern itoa=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/release/deps/libitoa-3eeebcc7091c9a8d.rmeta --extern lazy_static=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/release/deps/liblazy_static-12ecf5dd64302b40.rmeta --extern log=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/release/deps/liblog-b1a96f3c8da483b4.rmeta --extern malloc_size_of=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/release/deps/libmalloc_size_of-3ae4b9e3ee7e1e4c.rmeta --extern malloc_size_of_derive=/builds/worker/workspace/obj-build/release/deps/libmalloc_size_of_derive-c627da4da63b1c27.so --extern matches=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/release/deps/libmatches-189e3777c6c3fd05.rmeta --extern debug_unreachable=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/release/deps/libdebug_unreachable-d37aa985de69dc65.rmeta --extern nsstring=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/release/deps/libnsstring-527dd0d38a003c9d.rmeta --extern num_derive=/builds/worker/workspace/obj-build/release/deps/libnum_derive-6155b76da5a790e3.so --extern num_integer=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/release/deps/libnum_integer-34869d239f5082d3.rmeta --extern num_traits=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/release/deps/libnum_traits-b0bf699ff1cfb357.rmeta --extern num_cpus=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/release/deps/libnum_cpus-734754d0adcdcbe8.rmeta --extern owning_ref=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/release/deps/libowning_ref-1fe15c532820cea9.rmeta --extern 'noprelude:panic_abort=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/release/deps/libpanic_abort-deaa2495db1134f1.rmeta' --extern 'noprelude:panic_unwind=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/release/deps/libpanic_unwind-e4aeecf9dad7c685.rmeta' --extern parking_lot=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/release/deps/libparking_lot-ad6791d8f6c269d4.rmeta --extern precomputed_hash=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/release/deps/libprecomputed_hash-558902c7c926c610.rmeta --extern 'noprelude:proc_macro=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/release/deps/libproc_macro-f2175008e055be93.rmeta' --extern rayon=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/release/deps/librayon-2e94f694eb2463f6.rmeta --extern selectors=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/release/deps/libselectors-380b22373caf34be.rmeta --extern serde=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/release/deps/libserde-bd6a148d05986eca.rmeta --extern servo_arc=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/release/deps/libservo_arc-2b9f269e67a0273a.rmeta --extern smallbitvec=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/release/deps/libsmallbitvec-c8a14f6a5c882cfa.rmeta --extern smallvec=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/release/deps/libsmallvec-b6807e93fb3380ca.rmeta --extern static_prefs=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/release/deps/libstatic_prefs-e1096ef6db0fb0c4.rmeta --extern 'noprelude:std=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/release/deps/libstd-92cd010f9770d9f1.rmeta' --extern style_derive=/builds/worker/workspace/obj-build/release/deps/libstyle_derive-f26e01fd0e77a353.so --extern style_traits=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/release/deps/libstyle_traits-7724f88fbd9a85b0.rmeta --extern thin_slice=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/release/deps/libthin_slice-ea2210045c046d28.rmeta --extern time=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/release/deps/libtime-e3da31e5cbfabb3d.rmeta --extern to_shmem=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/release/deps/libto_shmem-b198ad376b6f9ebc.rmeta --extern to_shmem_derive=/builds/worker/workspace/obj-build/release/deps/libto_shmem_derive-f1470b853030e7f6.so --extern uluru=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/release/deps/libuluru-0eec90ec9bd3d1f0.rmeta --extern unicode_bidi=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/release/deps/libunicode_bidi-ecc433d5c8cb4de7.rmeta --extern unicode_segmentation=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/release/deps/libunicode_segmentation-e7e2b8f8bda2c32e.rmeta --extern void=/builds/worker/workspace/obj-build/x86_64-unknown-linux-gnu/release/deps/libvoid-d4133999c12e2c18.rmeta -Z unstable-options -C debuginfo=2 --cap-lints warn -Zsanitizer=thread -Cembed-bitcode=yes -C codegen-units=1` (exit status: 1)
[task 2021-09-21T00:29:17.510Z] 00:29:17    ERROR -  gmake[4]: *** [/builds/worker/checkouts/gecko/config/makefiles/rust.mk:404: force-cargo-library-build] Error 101
[task 2021-09-21T00:29:17.510Z] 00:29:17     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/toolkit/library/gtest/rust'
[task 2021-09-21T00:29:17.510Z] 00:29:17    ERROR -  gmake[3]: *** [/builds/worker/checkouts/gecko/config/recurse.mk:72: toolkit/library/gtest/rust/target] Error 2
[task 2021-09-21T00:29:17.510Z] 00:29:17     INFO -  gmake[3]: *** Waiting for unfinished jobs....

Comment 5

[Junjie Ying]

Attachment: Bug 1719939 - Remove last fragments of code manually checking the browser.proton.enabled pref. r=mhowell,mtigley

Depends on D126856

Comment 6

[Junjie Ying]

Attachment: Bug 1719939 - Remove last fragments of code manually checking the browser.proton.enabled pref. r=mhowell,mtigley

Depends on D127190

Comment 7

[:Gijs (he/him)]

Attachment: Bug 1719939 - remove browser.proton.enabled from new tab code, r?mviar

Comment 8

[:Gijs (he/him)]

Attachment: Bug 1719939 - remove browser.proton.enabled from network error page code, r?jaws

Depends on D134308

Comment 9

[:Gijs (he/him)]

Attachment: Bug 1719939 - remove proton checks from about:addons, r?mstriemer

The CSS that made the arrows work already got removed in bug 1714462.

Depends on D134309

Comment 10

[:Gijs (he/him)]

Attachment: Bug 1719939 - remove other mentions of browser.proton.enabled, r?jaws

Depends on D134310

Comment 11

[:Gijs (he/him)]

Attachment: Bug 1719939 - remove proton pref from static pref list and its last C++ consumer, r?jaws,mstange,harry

Depends on D134311

Comment 12

[:Gijs (he/him)]

https://treeherder.mozilla.org/jobs?repo=try&revision=0cae7e31a218c9fdd84b63d1bf1c2874c9c9fbd5

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5e7d0afa46c6
remove browser.proton.enabled from new tab code, r=mviar
https://hg.mozilla.org/integration/autoland/rev/df9a9b0ea251
remove browser.proton.enabled from network error page code, r=jaws
https://hg.mozilla.org/integration/autoland/rev/cf593264cb80
remove proton checks from about:addons, r=rpl
https://hg.mozilla.org/integration/autoland/rev/bb1e3bfae98c
remove other mentions of browser.proton.enabled, r=jaws
https://hg.mozilla.org/integration/autoland/rev/af8465c1e69b
remove proton pref from static pref list and its last C++ consumer, r=mstange

Comment 14

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/5e7d0afa46c6
https://hg.mozilla.org/mozilla-central/rev/df9a9b0ea251
https://hg.mozilla.org/mozilla-central/rev/cf593264cb80
https://hg.mozilla.org/mozilla-central/rev/bb1e3bfae98c
https://hg.mozilla.org/mozilla-central/rev/af8465c1e69b