1719985 - Port bug 1717680: Remove document.popupNode and document.tooltipNode

Status: RESOLVED FIXED

(Thunderbird :: Upstream Synchronization, task)

Comment 1

[Richard Marti (:Paenglab)]

Attachment: WIP: 1719985-remove-popupnode-tooltipnode.patch

This works almost, I think. Except the goCopyImage() function in utilityOverlay.js which gives a undefined back.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: 1719985-remove-popupnode-tooltipnode.patch

This patch should be ready except for the MsgComposeCommands.js. An earlier try https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=6b48f24b956fb3dcf3dd125d0ab86dba2b4f1e77 which had eslint errors that are fixed, except again the MsgComposeCommands.js. I removed the change because it didn't fix the issue.

Geoff, could you help me and fix this part? I don't know how to fix this.

Comment 4

[Richard Marti (:Paenglab)]

Attachment: 1719985-remove-popupnode-tooltipnode.patch

Added something to MsgComposeCommands.js but I still get this error: JavaScript error: resource://gre/modules/InlineSpellChecker.jsm, line 472: TypeError: can't access property "ownerGlobal", element is null. I don't know how to fix this.

Comment 5

[Magnus Melin [:mkmelin]]

Comment on attachment 9230626 [details] [diff] [review]
1719985-remove-popupnode-tooltipnode.patch

Review of attachment 9230626 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, I'll land in a sec! r=mkmelin

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/47085882a29d
Port bug 1717680: Remove document.popupNode and document.tooltipNode. r=mkmelin

Comment 7

[Richard Marti (:Paenglab)]

Geoff, please can you still look at the issue with MsgComposeCommands.js?

Comment 8

[Neil Deakin]

(In reply to Richard Marti (:Paenglab) from comment #4)

Created attachment 9230626 [details] [diff] [review]
1719985-remove-popupnode-tooltipnode.patch

Added something to MsgComposeCommands.js but I still get this error: JavaScript error: resource://gre/modules/InlineSpellChecker.jsm, line 472: TypeError: can't access property "ownerGlobal", element is null. I don't know how to fix this.

Does document.popupRangeParent get you the right node? This is how firefox currently gets the word that was context-clicked for spellchecking.

Comment 9

[Richard Marti (:Paenglab)]

(In reply to Neil Deakin from comment #8)

Does document.popupRangeParent get you the right node? This is how firefox currently gets the word that was context-clicked for spellchecking.

This works, but I still get the error.

Comment 10

[Richard Marti (:Paenglab)]

Attachment: 1719985-change-MsgComposeCommands.patch

Neil's proposal to use document.popupRangeParent.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/32bb960b0759
follow-up - Use triggerNode of tabContextMenu even for submenus. rs=bustage-fix

Comment 12

[Geoff Lankow (:darktrojan)]

Comment on attachment 9230637 [details] [diff] [review]
1719985-change-MsgComposeCommands.patch

You're right, it doesn't work either. I've found a way.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/735244108b31
Fix context menu in compose window editor. rs=me

Comment 14

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1719985 - Fix context menu in compose window editor, take 2. r=mkmelin

This time also working on Mac, which for some unknown reason has popup.screenX/Y equal to editor.screenX/Y.

Comment 15

[Magnus Melin [:mkmelin]]

Patch doesn't apply at all (possibly due to something else lined up.)

Comment 16

[Magnus Melin [:mkmelin]]

Oh, ignore me...

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/cbe00a747440
Fix context menu in compose window editor, take 2. r=mkmelin