1720023 - [perma] toolkit/components/search/tests/xpcshell/test_searchSuggest_cookies.js | setup - [setup : 100] The cache should be empty - 1 == 0

Status: RESOLVED FIXED

(Thunderbird :: Upstream Synchronization, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: mkmelin [at] iki.fi
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=344767746&repo=comm-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/beoUUAarRQKbfk6vT-NQZQ/runs/0/artifacts/public/logs/live_backing.log

---

Comment 1

[Magnus Melin [:mkmelin]]

Something from https://hg.mozilla.org/mozilla-central/pushloghtml?changeset=9b0fc6f1555b248ec451d0947a85ed224847fdec

Comment 2

[Intermittent Failures Robot]

1 failures in 2387 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 1

Platform and build breakdown:

• windows10-64-shippable-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1720023&startday=2021-07-05&endday=2021-07-11&tree=all

Comment 3

[Intermittent Failures Robot]

21 failures in 2224 pushes (0.009 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 21

Platform and build breakdown:

• windows10-64-qr: 9
  • debug: 4
  • opt: 5
• windows10-64-shippable-qr: 5
  • opt: 5
• windows7-32-qr: 1
  • opt: 1
• windows7-32-shippable-qr: 2
  • opt: 2
• windows10-64: 4
  • opt: 4

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1720023&startday=2021-07-12&endday=2021-07-18&tree=all

Comment 4

[Geoff Lankow (:darktrojan)]

If I copy services/settings/dumps/main/hijack-blocklists.json to mail/app/settings/dumps/thunderbird, the test passes. Currently it goes looking for the file and doesn't find it, but it looks like Windows reacts differently when it doesn't find it (no idea why), and that's why the failure only appears there.

Andrei, ISTR you know things about the remote settings. Can we just take this file and add it to the build, or is it more complicated than that?

Comment 5

[Andrei Hajdukewycz [:sancus]]

(In reply to Geoff Lankow (:darktrojan) from comment #4)

Andrei, ISTR you know things about the remote settings. Can we just take this file and add it to the build, or is it more complicated than that?

So, my knowledge of remote settings is limited to the fact that it's a Kinto instance where Firefox likes to dump big blobs of poorly documented JSON data, and we're stuck replicating it every time errors show up.

Looking at the data it appears to be what it says on the tin, some kind of blocklist, so I don't see any reason it would need modification for us.

Does having the dump there also resolve Bug 1721045 ?? Or is this dump only used for the tests?

Comment 6

[Geoff Lankow (:darktrojan)]

Does having the dump there also resolve Bug 1721045 ?? Or is this dump only used for the tests?

I just tried it in beta and unfortunately not, it still goes looking for updates.

Comment 7

[Geoff Lankow (:darktrojan)]

I'll install a local copy of the data to shut the test up. Even an empty one should do the trick.

Comment 8

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1720023 - Add hijack-blocklists settings dump with no entries. r=sancus

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/bdc02fa8c85e
Add hijack-blocklists settings dump with no entries. r=sancus

Comment 10

[Rob Lemley [:rjl]]

Comment on attachment 9232527 [details]
Bug 1720023 - Add hijack-blocklists settings dump with no entries. r=sancus

[Approval Request Comment]
Fix for test failure.

Comment 11

[Wayne Mery (:wsmwk)]

Comment on attachment 9232527 [details]
Bug 1720023 - Add hijack-blocklists settings dump with no entries. r=sancus

[Triage Comment]
Approved for beta

Comment 12

[Intermittent Failures Robot]

8 failures in 2940 pushes (0.003 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 8

Platform and build breakdown:

• windows10-64: 8
  • opt: 8

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1720023&startday=2021-07-19&endday=2021-07-25&tree=all

Comment 13

[Rob Lemley [:rjl]]

Thunderbird 91.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/af68d71be824