1720060 - Offerup browse page gets stuck after a few pages (infinite scroll)

Status: RESOLVED WORKSFORME

(Web Compatibility :: Site Reports, defect, P1)

Description

[Asif Youssuff]

Opening in GeckoView because I can reproduce in Reference Browser and Fenix but not in responsive page view on desktop.

1. Open: https://offerup.com/explore/k/1/6?delivery_param=s
2. Scroll down a few times.

What happens:

Infinite spinner and more content does not load.

Expected result:

More items display.

Profile: https://share.firefox.dev/2UAAKX8

On a Pixel 2 and profile was recorded in Reference Browser.

Tried mozregression with gve and found that the issue exists as far back as 2020-12-14.

Comment 1

[Emily Toop (:fluffyemily)]

We'll take a look at the profile and see which team this bug belongs with

Comment 2

[Emily Toop (:fluffyemily)]

This looks like a webcompat thing.

Comment 3

[Karl Dubost💡 :karlcow]

in The profile This never loads, but I'm not sure it's related.
https://offerup.com/1.16.0-fa992569-7b4a-4b80-a318-806b49e8df8e/_next/static/chunks/pages/item/detail/%5Bid%5D-07a1d2bb6ec65ac9a75b.js

If I tried to go to https://offerup.com/explore/k/1/6?delivery_param=s
I get an Error 1020.
So I don't think I can do anything to diagnose.

Does it still happen?

Comment 4

[Asif Youssuff]

Karl, it does still happen - maybe you need to be in a served region?

Comment 5

[Karl Dubost💡 :karlcow]

which region are you in? :)

Comment 6

[Asif Youssuff]

I'm in the US. I think it ought to work anywhere in the US.

Comment 7

[Karl Dubost💡 :karlcow]

Maybe Ksenia can help then.

Comment 8

[Oana Arbuzov [:oanaarbuzov]]

I can't access the site either (1020 error code) from my location (Romania) or using a VPN pointing to US.

Any luck on your side Ksenia?

Comment 9

[Ksenia Berezina [:ksenia]]

This is related to the Dynamic Toolbar and IntersectionObserver. When I scroll to the bottom of the page, it doesn't fire:

            i = new IntersectionObserver((function (e) {
              e.forEach((function (e) {
                var t = r.get(e.target),
                n = e.isIntersecting || e.intersectionRatio > 0;
                t && n && t(n)
              }))
            }), { rootMargin: "200px" });

However, it starts working if turn on Dynamic Toolbar (Settings > Customize > Scroll to hide toolbar -> off)
This looks similar to https://bugzilla.mozilla.org/show_bug.cgi?id=1788504

Comment 10

[Raul Bucata]

I can not access the webpage, even with a VPN connection, as I get a message that the page is only available in the US. Asif, is the issue still reproducible?

Comment 11

[Asif Youssuff]

Raul, I can still reproduce this issue.

Ksenia's workaround continues to work, however:

However, it starts working if turn on Dynamic Toolbar (Settings > Customize > Scroll to hide toolbar -> off)

Comment 12

[Raul Bucata]

Verified the issue but could not access the page due to Geo location restrictions. Ksenia, any updates on the issue?

Comment 13

[Ksenia Berezina [:ksenia]]

We can ship an intervention to make up for the height of the dynamic toolbar, this makes the infinite scroll work:

#__next::after {
  display: block;
  width: 100%;
  height: 10px;
  content: "";
}

Comment 14

[Ksenia Berezina [:ksenia]]

A sitepatch is shipped in bug1876363

Comment 15

[Hiroyuki Ikezoe (:hiro)]

Unfortunately the site is not usable for me just like Karl. :/

Comment 16

[Daniel Holbert [:dholbert]]

The site loads for me (in California), and I can't reproduce the bug, using Firefox Nightly on a Pixel 8.

I have "scroll to hide toolbar" enabled (by default) and I disabled the intervention from about:compat in the "interventions" section, so I don't think I'm benefiting from any workaround.

Asif, would you mind checking again to see if you can still reproduce (with dynamic toolbar on and with the intervention disabled)? I see that you could repro about a year ago (comment 11) but I wonder if maybe the site and/or Firefox changed such that the problem doesn't happen anymore.

Comment 17

[Daniel Holbert [:dholbert]]

(and/or ksenia, maybe you can retest, since it sounds like maybe you were able to repro in comment 13?)

Comment 18

[Daniel Holbert [:dholbert]]

(FWIW I tested (with intervention disabled) on two older phones that I have handy for testing -- a Pixel 4 and a Pixel 6a -- and was unable to repro on those, too.)

Comment 19

[Ksenia Berezina [:ksenia]]

I can't reproduce this either anymore with the intervention disabled, so I think we can close this as worksforme and remove the intervention.

Comment 20

[Dennis Schubert [:denschub]]

Attachment: Bug 1720060 - Remove remaining intervention files from the offerup.com intervention. r?twisniewski

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0690d411cd31
Remove remaining intervention files from the offerup.com intervention. r=twisniewski,webcompat-reviewers

Comment 22

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/0690d411cd31