Closed Bug 1720066 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 29636 - [cpu-profiler] Require specification of maxBufferSize

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox92 fixed)

Status:
RESOLVED FIXED
Milestone:
92 Branch
Tracking Flags:
Tracking Status
firefox92 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29636 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29636
Details from upstream follow.

b'Andrew Comminos <acomminos@fb.com>' wrote:

[cpu-profiler] Require specification of maxBufferSize

Make the Blink implementation consistent with the spec, requiring
maxBufferSize to be specified for profiler instantiation.

Bug: 956688
Change-Id: Icbb85a4679b91bf47e6a173c9f048bb004c66cd0
Reviewed-on: https://chromium-review.googlesource.com/3019395
WPT-Export-Revision: adae17f5eebe7176c969f2ee01a6029bf25f9dd9

CI Results

Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 16 subtests

Status Summary

Firefox

OK : 1
PASS: 1
FAIL: 15

Chrome

OK : 1
PASS: 9
FAIL: 7

Safari

OK : 1
PASS: 1
FAIL: 15

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/js-self-profiling/idlharness.https.html
idl_test setup: FAIL (Chrome: FAIL, Safari: FAIL)
Profiler interface: existence and properties of interface object: FAIL (Chrome: PASS, Safari: FAIL)
Profiler interface object length: FAIL (Chrome: FAIL, Safari: FAIL)
Profiler interface object name: FAIL (Chrome: PASS, Safari: FAIL)
Profiler interface: existence and properties of interface prototype object: FAIL (Chrome: PASS, Safari: FAIL)
Profiler interface: existence and properties of interface prototype object's "constructor" property: FAIL (Chrome: PASS, Safari: FAIL)
Profiler interface: existence and properties of interface prototype object's @@unscopables property: FAIL (Chrome: PASS, Safari: FAIL)
Profiler interface: attribute sampleInterval: FAIL (Chrome: PASS, Safari: FAIL)
Profiler interface: attribute stopped: FAIL (Chrome: PASS, Safari: FAIL)
Profiler interface: operation stop(): FAIL (Chrome: PASS, Safari: FAIL)
Profiler must be primary interface of profiler: FAIL (Chrome: FAIL, Safari: FAIL)
Stringification of profiler: FAIL (Chrome: FAIL, Safari: FAIL)
Profiler interface: profiler must inherit property "sampleInterval" with the proper type: FAIL (Chrome: FAIL, Safari: FAIL)
Profiler interface: profiler must inherit property "stopped" with the proper type: FAIL (Chrome: FAIL, Safari: FAIL)
Profiler interface: profiler must inherit property "stop()" with the proper type: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fd6fd400d1dc
[wpt PR 29636] - [cpu-profiler] Require specification of maxBufferSize, a=testonly
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/15e218bd0132
[wpt PR 29636] - [cpu-profiler] Require specification of maxBufferSize, a=testonly

https://hg.mozilla.org/mozilla-central/rev/15e218bd0132

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox92: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
You need to log in before you can comment on or make changes to this bug.