172010 - voting broken on tip

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect, P1)

Description

[David Avery]

voting is broken on the current bugzilla tip - 

SELECT bugs.bug_id, reporter, assigned_to, qa_contact, reporter_accessible,
cclist_accessible, cc.who IS NOT NULL, COUNT(bug_group_map.group_id) as
cntbugingroups, COUNT(DISTINCT(user_group_map.group_id)) as cntuseringroups FROM
bugs LEFT JOIN cc ON bugs.bug_id = cc.bug_id AND cc.who = 2529 LEFT JOIN
bug_group_map ON bugs.bug_id = bug_group_map.bug_id LEFT JOIN user_group_map ON
user_group_map.group_id = bug_group_map.group_id AND user_group_map.isbless = 0
AND user_group_map.user_id = 2529 WHERE bugs.bug_id = 837 GROUP BY bugs.bug_id:
Table 'cc' was not locked with LOCK TABLES at globals.pl line 246.

Comment 1

[Joel Peshkin]

Attachment: Patch

Looks like a locking problem and a leftover from bug 43600.  Please give this
a try.

Comment 2

[David Avery]

patch appears to fix error - 

Comment 3

[Joel Peshkin]

I'll take this

Comment 4

[Bradley Baetz (:bbaetz)]

Comment on attachment 101313 [details] [diff] [review]
Patch

oops. r=bbaetz x2

Comment 5

[Joel Peshkin]

All fixed..... Nice catch

Checking in votes.cgi;                                       
/cvsroot/mozilla/webtools/bugzilla/votes.cgi,v  <--  votes.cgi
new revision: 1.7; previous revision: 1.6
done
Checking in CGI.pl;
/cvsroot/mozilla/webtools/bugzilla/CGI.pl,v  <--  CGI.pl
new revision: 1.180; previous revision: 1.179
done