Move Exchange autodiscover code into a JSM
Categories
(Thunderbird :: Account Manager, task)
Tracking
(thunderbird_esr78 unaffected, thunderbird_esr91+ fixed, thunderbird91 affected)
Tracking | Status | |
---|---|---|
thunderbird_esr78 | --- | unaffected |
thunderbird_esr91 | + | fixed |
thunderbird91 | --- | affected |
People
(Reporter: neil, Assigned: neil)
References
Details
Attachments
(1 file)
10.60 KB,
patch
|
darktrojan
:
review+
BenB
:
review+
wsmwk
:
approval-comm-esr91+
|
Details | Diff | Splinter Review |
Bug 1717334 didn't do that for some reason, which introduced a possible race condition whereby Exchange autodiscover finds an HTTP redirect, waits 2 seconds in case another detection succeeds, but then finds that it can't cancel the timeout because TimeoutAbortable
only understands Timer.jsm
's timeouts and this is still using window.setTimeout
.
Assignee | ||
Comment 1•3 years ago
|
||
I had to add extra parameters so that I could pass the confirmExchange
function from the UI to ExchangeAutoDiscover.jsm
(obviously the JSM isn't in a position to do any prompting itself).
Comment 2•3 years ago
|
||
Comment on attachment 9230804 [details] [diff] [review]
Proposed patch
r=BenB, but darktrojan should review as well
Updated•3 years ago
|
Updated•3 years ago
|
Comment 3•3 years ago
|
||
Let's get this landed as well. Started a try run just now: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=c5657163b2b92384e237dba30da0aa8e0ebedf96
Pushed by thunderbird@calypsoblue.org:
https://hg.mozilla.org/comm-central/rev/b714b6a3def3
Move Exchange autodiscovery into a JSM. r=BenB,darktrojan
Updated•3 years ago
|
Comment 6•3 years ago
|
||
This was fixed in TB 92, ESR 91 uplift still not requested. Who is managing this?
Comment 7•3 years ago
|
||
It's really up to patch authors to request uplift.
Comment 8•3 years ago
|
||
Comment on attachment 9230804 [details] [diff] [review]
Proposed patch
[Approval Request Comment]
Regression caused by (bug #): semi-regression from bug 1717734
User impact if declined: potential UI confusion
Testing completed (on c-c, etc.): been on c-c and beta for a while
Risk to taking this patch (and alternatives if risky): should be fairly safe, but could do with manual testing after uplift
Comment 9•3 years ago
|
||
(In reply to Magnus Melin [:mkmelin] from comment #7)
It's really up to patch authors to request uplift.
How do you manage situations where the patch author for one reason or another doesn't request uplift, but - unlike in this case - the patch fixes a regression?
Comment 10•3 years ago
|
||
Comment on attachment 9230804 [details] [diff] [review]
Proposed patch
[Triage Comment]
Approved for esr91
Comment 11•3 years ago
|
||
bugherder uplift |
Thunderbird 91.1.0:
https://hg.mozilla.org/releases/comm-esr91/rev/65f586ab0c8a
Description
•