Closed Bug 1720239 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 29646 - Turn Critical-CH restarts into internal redirects

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox92 fixed)

Status:
RESOLVED FIXED
Milestone:
92 Branch
Tracking Flags:
Tracking Status
firefox92 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29646 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29646
Details from upstream follow.

b'Aaron Tagliaboschi <aarontag@chromium.org>' wrote:

Turn Critical-CH restarts into internal redirects

This fixes a number of issues, including crashes. Unfortunately, this
will not fix issues with ACCEPT_CH, which is having a very similar
crasher problem.

Bug: 1228536
Change-Id: I8401c67818cdd6cf16a75422b2ba48fe429dc961

Reviewed-on: https://chromium-review.googlesource.com/2983659
WPT-Export-Revision: bada484cf559a10e96c2e67ea6ca6c1fb3134cc3

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 8 tests and 1 subtests

Status Summary

Firefox

OK : 8
PASS : 3
FAIL : 5

Chrome

OK : 8
PASS : 8

Safari

TIMEOUT: 16

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/client-hints/service-workers/intercept-request.https.html
Service workers succsefully receives hints from request: FAIL (Chrome: PASS, Safari: TIMEOUT)
/client-hints/service-workers/navigation-preload-critical.https.window.html
Service worker successfully passes hints through to new fetch: FAIL (Chrome: PASS, Safari: TIMEOUT)
/client-hints/service-workers/navigation-preload.https.html
Service worker successfully passes hints through to new fetch: FAIL (Chrome: PASS, Safari: TIMEOUT)
/client-hints/service-workers/passthrough-request-critical.https.window.html
Service worker successfully passes hints through to new fetch: FAIL (Chrome: PASS, Safari: TIMEOUT)
/client-hints/service-workers/passthrough-request.https.html
Service worker successfully passes hints through to new fetch: FAIL (Chrome: PASS, Safari: TIMEOUT)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f6ce662d9386
[wpt PR 29646] - Turn Critical-CH restarts into internal redirects, a=testonly
https://hg.mozilla.org/integration/autoland/rev/215c0dc445a6
[wpt PR 29646] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/f6ce662d9386
https://hg.mozilla.org/mozilla-central/rev/215c0dc445a6

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox92: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
You need to log in before you can comment on or make changes to this bug.