1720247 - Menu bar menu titles are almost invisible with dark themes in Firefox 90

Status: RESOLVED DUPLICATE of bug 1720441

(Firefox :: Theme, defect, P2)

Description

[Graham Perrin]

Attachment: Mozilla Dark 1.2 bugged in my everyday 'default' profile

User Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:90.0) Gecko/20100101 Firefox/90.0

Steps to reproduce:

1. on or before 2021-01-30, I installed the Computer Terminal theme
   https://addons.mozilla.org/addon/computer-terminal/

2. with Firefox 89, menu titles were visible – good contrast in the menu bar

3. I updated from 89.0.2 to 90

Actual results:

4. menu titles became almost invisible (maybe 95% grey text, black background)

5. pointing at a title causes it to flicker, with good contrast, momentarily

6. clicking a title causes the title (and its menu) to become visible, legible

7. numerous dark themes are bugged, including Mozilla's own Dark (1.2) in a separate profile.

Expected results:

4. the menu bar should use sane contrast to present clearly visible menu titles.

Comment 1

[Graham Perrin]

Attachment: Mozilla Dark 1.2 bugged with my 'test' profile in safe mode

Comment 2

[Graham Perrin]

Attachment: Computer Terminal (1.0) bugged in Firefox 90

Inset: the theme as it was with Firefox 85. https://i.imgur.com/il3CAJm.png referred from https://addons.mozilla.org/addon/computer-terminal/reviews/1658796/ – note the use of amber for menu titles.

Comment 3

[Graham Perrin]

Environment

% date ; uname -KUv
Tue 13 Jul 2021 04:42:37 BST
FreeBSD 14.0-CURRENT #100 main-n247798-f39dd6a9784: Thu Jul  8 07:38:23 BST 2021     root@mowa219-gjp4-8570p:/usr/obj/usr/src/amd64.amd64/sys/GENERIC-NODEBUG  1400025 1400025
% grep pkg /var/log/messages | grep firefox
Jul 12 10:24:38 mowa219-gjp4-8570p pkg[2528]: firefox upgraded: 89.0.2_1,2 -> 90.0,2 
% 

https://www.freshports.org/www/firefox/

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Theme' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 5

[Pablo]

I tried to reproduce on windows 10 64bit and Ubuntu 20 64bit but i see the menu with orange letters. (tested release 90, beta 91.0b2 and nightly 92.0a1)

Perhaps this issue only happens with FreeBSD only

Does this issue occur in the latest nightly version of firefox? Here is a link from where you can download it:
https://www.mozilla.org/en-US/firefox/channel/desktop/

Comment 6

[Graham Perrin]

From https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=257225:

Please consider cherry-picking cc6f1271888c for the next build of www/firefox

Comment 7

[Graham Perrin]

Attachment: Adwaita KDE (global theme)

I tried a change of appearance, Mozilla Dark remained bugged with Adwaita KDE …

Comment 8

[Graham Perrin]

Attachment: cleanlooks (application style)

… cleanlooks …

Comment 9

[Graham Perrin]

Attachment: ClassicLooks (GTK theme)

… and ClassicLooks.

Comment 10

[Graham Perrin]

Cross reference, in Reddit:

Menu text font color : firefox

Since version 90 on Linux all dark themes I try have invisible menu text. …

Comment 11

[Graham Perrin]

(In reply to Graham Perrin from comment #6)

Fixed in Firefox 90.0.1,2 on FreeBSD. Commits to latest and quarterly:

• https://cgit.freebsd.org/ports/commit/?id=e1a591344ba3f7593c3a2a4697ce08e377f78f97&h=main
• https://cgit.freebsd.org/ports/commit/?id=0858bd828885d283406a4c8629a702dd2251deff&h=2021Q3

Comment 12

[:Gijs (he/him)]

The commit that fixed it in the freebsd repos points to bug 1720441, so I assume this should just be treated as a dupe.