1720262 - [Clear Recent History Modal] Please adjust the spacing around the Cancel and OK Button area

Status: VERIFIED FIXED

(Toolkit Graveyard :: Notifications and Alerts, defect)

Description

[Mehmet]

Attachment: Actual_vs_Expected.png

Nightly 92.0a1 (2021-07-12) (64-Bit)
macOS 11.15.7 & 11.4

Follow-Up of bug 1712750.

1.) Open a New Window
2.) Open the new Clear Recent History Modal
3.) Take a look at the spacing around the Cancel and OK Button area

Actual: The spacing look off.

Expected: Polished spacing.

Thanks :)

Comment 2

[:Gijs (he/him)]

I'm not really sure where the "expected" case has come from - I think the proton spec is probably a bit more space than in the "expected" one (16px spacing + 4px spacing above/below the checkbox) - but I think the horizontal spacing also looks wrong on Windows (more wrong than in the mac screenshot) so I'm fixing a bunch of it.

Comment 3

[:Gijs (he/him)]

Attachment: Bug 1720262 - improve spacing in the window-modal clear recent history dialog, r?mconley

Depends on D120984

Comment 4

[Mehmet]

The "expected" case was only a free-hand mockup from me :)

Thanks a lot in advance for fixing this :)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/22014e5ee92c
improve spacing in the window-modal clear recent history dialog, r=mconley

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/22014e5ee92c

Comment 7

[Mehmet]

Thanks, looks great in Nightly 92.0a1 (2021-08-02) (64-Bit).

Comment 8

[Rares Doghi, Desktop QA]

This issue is Verified as fixed in our latest build 92.0a1 (2021-08-02) on Windows , Mac and Ubuntu.