Close button of Junk info bar white on yellow with dark theme
Categories
(Thunderbird :: Theme, defect)
Tracking
(thunderbird91 fixed)
Tracking | Status | |
---|---|---|
thunderbird91 | --- | fixed |
People
(Reporter: Paenglab, Assigned: Paenglab)
Details
Attachments
(1 file, 1 obsolete file)
912 bytes,
patch
|
Paenglab
:
review+
wsmwk
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
With the dark theme the close button of the yellow Junk info bar is white instead of black.
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 1•3 years ago
|
||
We need to override the common.css styles to use the colour that correlates to the bar background and not the theme colour.
Comment 2•3 years ago
|
||
Assignee | ||
Comment 3•3 years ago
|
||
Updated the commit message.
Assignee | ||
Updated•3 years ago
|
Pushed by thunderbird@calypsoblue.org:
https://hg.mozilla.org/comm-central/rev/2d3a5af101f8
Fix the notification bar close button color. r=aleca
Assignee | ||
Comment 5•3 years ago
|
||
Comment on attachment 9231018 [details] [diff] [review]
1720336-message-bar-close-color.patch
[Approval Request Comment]
User impact if declined: junk notification bar close button with dark theme almost not visible
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low
Comment 6•3 years ago
|
||
Comment on attachment 9231018 [details] [diff] [review]
1720336-message-bar-close-color.patch
[Triage Comment]
Approved for beta
Comment 7•3 years ago
|
||
bugherder uplift |
Thunderbird 91.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/ede3cb709226
Description
•