Closed Bug 1720336 Opened 3 years ago Closed 3 years ago

Close button of Junk info bar white on yellow with dark theme

Categories

(Thunderbird :: Theme, defect)

defect

Tracking

(thunderbird91 fixed)

RESOLVED FIXED
92 Branch
Tracking Status
thunderbird91 --- fixed

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file, 1 obsolete file)

With the dark theme the close button of the yellow Junk info bar is white instead of black.

We need to override the common.css styles to use the colour that correlates to the bar background and not the theme colour.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9231003 - Flags: review?(alessandro)
Comment on attachment 9231003 [details] [diff] [review] 1720336-message-bar-close-color.patch Review of attachment 9231003 [details] [diff] [review]: ----------------------------------------------------------------- This is good, thanks. Please, update the commit message with `"Fix the notification bar close button color."` as this fixes also the close button color in the openpgp high priority alert notifications with default/light theme.
Attachment #9231003 - Flags: review?(alessandro) → review+

Updated the commit message.

Attachment #9231003 - Attachment is obsolete: true
Attachment #9231018 - Flags: review+
Target Milestone: --- → 92 Branch

Pushed by thunderbird@calypsoblue.org:
https://hg.mozilla.org/comm-central/rev/2d3a5af101f8
Fix the notification bar close button color. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED

Comment on attachment 9231018 [details] [diff] [review]
1720336-message-bar-close-color.patch

[Approval Request Comment]
User impact if declined: junk notification bar close button with dark theme almost not visible
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Attachment #9231018 - Flags: approval-comm-beta?

Comment on attachment 9231018 [details] [diff] [review]
1720336-message-bar-close-color.patch

[Triage Comment]
Approved for beta

Attachment #9231018 - Flags: approval-comm-beta? → approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: