Closed
Bug 1720344
Opened 3 years ago
Closed 3 years ago
Add a test to ensure setting open attribute doesn't fire the 'close' event
Categories
(Core :: DOM: Core & HTML, defect, P3)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
92 Branch
| Tracking | Status | |
|---|---|---|
| firefox92 | --- | fixed |
People
(Reporter: sefeng, Assigned: sefeng)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
This doesn't align with the spec
|
Assignee | |
Updated•3 years ago
|
Assignee: nobody → sefeng
|
|
Assignee | |
Comment 1•3 years ago
|
||
This is for aligning the idl with the spec.
|
|
Assignee | |
Comment 2•3 years ago
|
||
Added a test to ensure setting the open attribute to false doesn't
fire the close event.
Depends on D119796
|
||
Updated•3 years ago
|
Severity: -- → S3
Priority: -- → P3
|
||
Updated•3 years ago
|
Attachment #9231027 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 3•3 years ago
|
||
Repurpose the bug as it is not worth changing the webidl.
Summary: Remove SetterThrows from HTMLDialogElement.webidl for the open attribute → Add a test to ensure setting open attribute doesn't fire the 'close' event
Pushed by sefeng@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9471574eb5d6 Add a <dialog> test for the setting the open attribute r=emilio
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/29660 for changes under testing/web-platform/tests
|
||
Comment 6•3 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox92:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
Upstream PR merged by nt1m
You need to log in
before you can comment on or make changes to this bug.
Description
•