1720405 - Get rid of the prefs for bug 1496288 from automated tests

Status: RESOLVED FIXED

(Core :: DOM: Events, task, P3)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

• dom.keyboardevent.keypress.set_keycode_and_charcode_to_same_value
• dom.keyboardevent.dispatch_during_composition
• dom.keyboardevent.keypress.dispatch_non_printable_keys_only_system_group_in_content
• dom.window.event.enabled

Those prefs will be never reverted by default in the release channel. So, we can drop them from automated tests unless the test checks the non-default behavior.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1720405 - part 1: Get rid of the pref check of `dom.keyboardevent.keypress.dispatch_non_printable_keys_only_system_group_in_content` from the tests r=smaug!

Its default value is true and it will never be reverted in release builds
by default. Therefore, we can get rid of it from the tests unless testing
non-default behavior.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1720405 - part 2: Get rid of the pref check/setting of `dom.keyboardevent.dispatch_during_composition` from the tests r=smaug!

It's default value is true. dom.keyboardevent.dispatch_during_composition
will never be reverted by default in release builds. So, we can drop it from
the tests unless testing the non-default behavior.

Depends on D119849

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1720405 - part 3: Get rid of the pref check/setting of `dom.keyboardevent.keypress.set_keycode_and_charcode_to_same_value` from the tests r=smaug!

It's default value is true.
dom.keyboardevent.keypress.set_keycode_and_charcode_to_same_value will neve
be reverted in release builds by default. Therefore, we can get rid of it
from the tests unless testing non-default behavior.

Depends on D119850

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1720405 - part 4: Get rid of the pref setting of `dom.window.event.enabled` from the tests r=smaug!

Its default value is true. dom.window.event.enabled will never be reverted
by default in release builds. So, we can drop it from our tests.

Depends on D119851

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3c0887f28d54
part 1: Get rid of the pref check of `dom.keyboardevent.keypress.dispatch_non_printable_keys_only_system_group_in_content` from the tests r=smaug
https://hg.mozilla.org/integration/autoland/rev/8e363910a39b
part 2: Get rid of the pref check/setting of `dom.keyboardevent.dispatch_during_composition` from the tests r=smaug
https://hg.mozilla.org/integration/autoland/rev/822d58965343
part 3: Get rid of the pref check/setting of `dom.keyboardevent.keypress.set_keycode_and_charcode_to_same_value` from the tests r=smaug
https://hg.mozilla.org/integration/autoland/rev/48daefb4914f
part 4: Get rid of the pref setting of `dom.window.event.enabled` from the tests r=smaug

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/3c0887f28d54
https://hg.mozilla.org/mozilla-central/rev/8e363910a39b
https://hg.mozilla.org/mozilla-central/rev/822d58965343
https://hg.mozilla.org/mozilla-central/rev/48daefb4914f