Templatized API for Typed Arrays and other data buffers
Categories
(Core :: JavaScript Engine, task, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox94 | --- | fixed |
People
(Reporter: sfink, Assigned: sfink)
References
Details
Attachments
(13 files, 1 obsolete file)
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review |
I would like to create a C++ API for accessing and manipulating ArrayBuffers and views of ArrayBuffers.
|
Assignee | |
Updated•3 years ago
|
|
|
Assignee | |
Comment 1•3 years ago
|
||
|
|
Assignee | |
Comment 2•3 years ago
|
||
|
|
Assignee | |
Comment 3•3 years ago
|
||
isDetached() (FIXME)
|
|
Assignee | |
Comment 4•3 years ago
|
||
|
|
Assignee | |
Comment 5•3 years ago
|
||
|
|
Assignee | |
Comment 6•3 years ago
|
||
|
|
Assignee | |
Comment 7•3 years ago
|
||
|
|
Assignee | |
Comment 8•3 years ago
|
||
|
|
Assignee | |
Comment 9•3 years ago
|
||
|
|
Assignee | |
Comment 10•3 years ago
|
||
|
|
Assignee | |
Comment 11•3 years ago
|
||
|
|
Assignee | |
Comment 12•3 years ago
|
||
|
|
Assignee | |
Comment 13•3 years ago
|
||
|
|
Assignee | |
Comment 14•3 years ago
|
||
|
||
Updated•3 years ago
|
|
|
||
Updated•3 years ago
|
|
||
Comment 15•3 years ago
|
||
Pushed by sfink@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/77ff4529ea3e Expose a templatized TypedArray<T> class in JSAPI r=jonco,nbp https://hg.mozilla.org/integration/autoland/rev/ae5f6b9ecf4a Switch structured cloning to use the templatized TypedArray<T> class. r=jonco https://hg.mozilla.org/integration/autoland/rev/677e4aa42b4d Make eg GetInt8ArrayData call TypedArray<Int8>::getData rather than the other way around (replace macros with function templates) r=jonco https://hg.mozilla.org/integration/autoland/rev/410e13fdf4e5 Move typed array unwrap API to templatized version r=jonco https://hg.mozilla.org/integration/autoland/rev/180daaed9cc8 Fill in the rest of the ArrayBuffer+ArrayBufferView hierarchy, and base more ArrayBufferViewObject public APIs off of new API r=jonco https://hg.mozilla.org/integration/autoland/rev/f212ab757312 Add (type)Array aliases, eg JS::Int8Array r=jonco https://hg.mozilla.org/integration/autoland/rev/b5bafd6f08d3 Convert the JS_GetObjectAs(type)Array APIs r=jonco https://hg.mozilla.org/integration/autoland/rev/16695064a637 Convert the JS_Is(type)Array APIs r=jonco https://hg.mozilla.org/integration/autoland/rev/23cc649c6e14 Move js::Scalar -> JS::Scalar for public API, but alias it as js::Scalar r=jonco https://hg.mozilla.org/integration/autoland/rev/6880cf8c51bc Switch DOM bindings typed arrays to using JSAPI templates r=jonco,smaug https://hg.mozilla.org/integration/autoland/rev/44c3e9e78d0a Support Rooted<...view type...> operations. r=jonco https://hg.mozilla.org/integration/autoland/rev/ccb7a164fe32 Add tests of new ArrayBufferOrView API r=jonco https://hg.mozilla.org/integration/autoland/rev/94293ba5a5a5 Fix hazards in TestingFunctions.cpp r=jonco
|
||
Comment 16•3 years ago
|
||
Backed out for hazards bustages on Cache.cpp
Backout link: https://hg.mozilla.org/integration/autoland/rev/cc0c313876cf2ff6bab9e590e9bded15b6582089
Log link: https://treeherder.mozilla.org/logviewer?job_id=348320072&repo=autoland&lineNumber=20324
|
||
Comment 17•3 years ago
|
||
There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:sfink, could you have a look please?
For more information, please visit auto_nag documentation.
|
|
||
Comment 18•3 years ago
|
||
Pushed by sfink@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0c3169618f2f Expose a templatized TypedArray<T> class in JSAPI r=jonco,nbp https://hg.mozilla.org/integration/autoland/rev/a66bd5c442a4 Switch structured cloning to use the templatized TypedArray<T> class. r=jonco https://hg.mozilla.org/integration/autoland/rev/4791d6790af7 Make eg GetInt8ArrayData call TypedArray<Int8>::getData rather than the other way around (replace macros with function templates) r=jonco https://hg.mozilla.org/integration/autoland/rev/2da058734d5c Move typed array unwrap API to templatized version r=jonco https://hg.mozilla.org/integration/autoland/rev/e0d16e395a5f Fix hazards in TestingFunctions.cpp r=jonco https://hg.mozilla.org/integration/autoland/rev/df0c1ee4d0b0 Fill in the rest of the ArrayBuffer+ArrayBufferView hierarchy, and base more ArrayBufferViewObject public APIs off of new API r=jonco https://hg.mozilla.org/integration/autoland/rev/456fc09d6816 Add (type)Array aliases, eg JS::Int8Array r=jonco https://hg.mozilla.org/integration/autoland/rev/2d444b132a3d Convert the JS_GetObjectAs(type)Array APIs r=jonco https://hg.mozilla.org/integration/autoland/rev/988eccbeb2ae Convert the JS_Is(type)Array APIs r=jonco https://hg.mozilla.org/integration/autoland/rev/5445f480023e Move js::Scalar -> JS::Scalar for public API, but alias it as js::Scalar r=jonco https://hg.mozilla.org/integration/autoland/rev/e162d996deac Switch DOM bindings typed arrays to using JSAPI templates r=jonco,smaug https://hg.mozilla.org/integration/autoland/rev/7c17e89fe77a Support Rooted<...view type...> operations. r=jonco https://hg.mozilla.org/integration/autoland/rev/31caca93507e Add tests of new ArrayBufferOrView API r=jonco
|
|
||
Comment 19•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/0c3169618f2f
https://hg.mozilla.org/mozilla-central/rev/a66bd5c442a4
https://hg.mozilla.org/mozilla-central/rev/4791d6790af7
https://hg.mozilla.org/mozilla-central/rev/2da058734d5c
https://hg.mozilla.org/mozilla-central/rev/e0d16e395a5f
https://hg.mozilla.org/mozilla-central/rev/df0c1ee4d0b0
https://hg.mozilla.org/mozilla-central/rev/456fc09d6816
https://hg.mozilla.org/mozilla-central/rev/2d444b132a3d
https://hg.mozilla.org/mozilla-central/rev/988eccbeb2ae
https://hg.mozilla.org/mozilla-central/rev/5445f480023e
https://hg.mozilla.org/mozilla-central/rev/e162d996deac
https://hg.mozilla.org/mozilla-central/rev/7c17e89fe77a
https://hg.mozilla.org/mozilla-central/rev/31caca93507e
|
|
Assignee | |
Comment 20•3 years ago
|
||
Weird, this flooded me with "Code Review bot found <n> build errors on <phabrev>" messages that complain about serious compile errors, but it seems to have stuck. I did build it locally before landing. I'm not sure what happened.
Description
•