172044 - Content area needs to handle the 'url ' drag flavor

Status: VERIFIED FIXED

(Camino Graveyard :: Drag & Drop, defect)

Description

[Simon Fraser [no longer active]]

To enable dragging of urls from the content into the dock, and to handle the
dropping links from some apps (e.g. Sherlock) in the content, we need to handle
the 'url ' and 'urld' flavors.

Comment 1

[Simon Fraser [no longer active]]

This should also fix the receiving of .webloc files from the Finder (bug 165303)

Comment 2

[Simon Fraser [no longer active]]

Attachment: Ugly first-pass patch; needs cleanup

Comment 3

[Simon Fraser [no longer active]]

I'll keep hacking.

Comment 4

[Simon Fraser [no longer active]]

*** Bug 165303 has been marked as a duplicate of this bug. ***

Comment 5

[Simon Fraser [no longer active]]

Attachment: mozilla/content/base/src patch

This patch adds XP flavors for URL and description, which is preferable to
mucking with the moz-url data which has url and title separated by a linebreak.
Note that when dragging an image, we add the image URL to the drag so that you
can drag images between browser windows.

This patch depends on the next one...

Comment 6

[Simon Fraser [no longer active]]

Attachment: mozilla/widget patch

This patch adds mappings of the OS types 'url ' and 'urld' to kURLDataMime and
kURLDescriptionMime, and the conversion between OS string data and unicode for
these types.

Comment 7

[Simon Fraser [no longer active]]

Reviews please, Mike.

These changes fix the following:
* Can drag a url to the dock to create a dock item for the url
* Can drag a .webloc file from the Finder into the browser, and have it load
  the url (rather than trying to load the file)
* Can drag an iamge from one browser window to another
* Can drag items from 'eBay' search results in Sherlock to the browser

Comment 8

[Mike Pinkerton (not reading bugmail)]

looks good to me. r=pink on both.

Comment 9

[Mike Pinkerton (not reading bugmail)]

just a thought, should we try to get the xul dnd code throughout mozilla to use
the new flavors and obsolete the url/ntitle flavor?

Comment 10

[Simon Fraser [no longer active]]

> just a thought, should we try to get the xul dnd code throughout mozilla to use
> the new flavors and obsolete the url/ntitle flavor?

That would be ideal, but might require hacking a bunch of front-ends. Doesn't
chimera mess with url\ntitle drag data? I think 4.x also did, so there may be
compatibility issues here. I'd recommend deprecating the moz-url flavor, but
still sending it, and handling it on recieve.

Comment 11

[Simon Fraser [no longer active]]

Checked in.

Comment 12

[Chris Petersen]

Verified items listed in comment 7 are functioning properly. Tested with the
2003-01-09-04 NB under 10.2.3. Marking verified.