1720441 - On Firefox 90, when using Yaru Colors GTK theme and Light Firefox theme, menu/button text is invisible (white on white)

Status: VERIFIED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[nyanpasu64]

Attachment: Firefox menu bar invisible on GNOME with "Title Bar" checked (system title bar).

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:90.0) Gecko/20100101 Firefox/90.0

Steps to reproduce:

I am running a Linux configured to use Yaru Colors (Yaru-Blue) GTK3 theme. This theme has dark title bars with light text, but light window backgrounds with dark text.

Firefox is configured to use the Light theme, which makes the tab bar's background light gray. And it's configured with "Title Bar" checked, which makes it use the system title bar.

I upgraded to Firefox 90.

Actual results:

The menu (whether permanently open or when pressing Alt) contains white-ish text (similar in color to active title bar text) on a light gray background, rendering the menu bar text practically invisible.

(With "Title Bar" unchecked, the menu text is visible, but the minimize and maximize buttons are now white on light gray, and also invisible.)

Switching to Yaru-Blue-Light (most apps have light title bars with dark text) fixes both issues in Firefox, even though with "Title Bar" checked, Firefox strangely still has a dark title bar unlike other apps with light title bars.

Expected results:

All text and icons should have consistent contrast.

Related: https://bugzilla.mozilla.org/show_bug.cgi?id=1720247

Comment 1

[nyanpasu64]

Also filed at https://github.com/Jannomag/Yaru-Colors/issues/109.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Emilio?

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1720441 - Remove unthemed menubar color. r=dao,stransky

Menubars on Linux are unthemed by default so they are transparent. Only
themed menubars should use -moz-menubarcolor.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cc6f1271888c
Remove unthemed menubar color. r=stransky

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/cc6f1271888c

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9231129 [details]
Bug 1720441 - Remove unthemed menubar color. r=dao,stransky

Beta/Release Uplift Approval Request

• User impact if declined: Menubar is white on white / black on white (with some combination of light themes and gtk themes).
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple CSS fix.
• String changes made/needed: none

Comment 8

[Pascal Chevrel:pascalc]

Comment on attachment 9231129 [details]
Bug 1720441 - Remove unthemed menubar color. r=dao,stransky

Low risk CSS fix, approved for 91 beta 5, thanks.

Comment 9

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/f34a9b8a971f

Comment 10

[Anca Soncutean, Desktop QA]

Reproduced with Fx 92.0a1 (14-07-2021) on Ubuntu 18.04.
Verified fixed with Fx 92.0a1 (19-06-2021) and Fx 91.0b5 (treeherder build) on Ubuntu 18.04.

Comment 13

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9231129 [details]
Bug 1720441 - Remove unthemed menubar color. r=dao,stransky

Beta/Release Uplift Approval Request

• User impact if declined: comment 0
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple CSS fix.
• String changes made/needed: none

Comment 14

[Julien Cristau [:jcristau]]

Comment on attachment 9231129 [details]
Bug 1720441 - Remove unthemed menubar color. r=dao,stransky

sounds like this is a new regression, multiple duplicates, and a simple fix; approved for 90.0.2

Comment 15

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-release/rev/da6bda3ff7b3

Comment 16

[Anca Soncutean, Desktop QA]

Verified fixed with Fx 90.0.2 on Ubuntu 18.04.