Closed Bug 1720494 Opened 5 years ago Closed 4 years ago

glean_parser's translate.transform only provides numerator names, not objects

Categories

(Data Platform and Tools :: Glean: SDK, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: chutten, Assigned: janerik)

References

Details

Attachments

(1 file)

In bug 1694496 I went to use translate.transform to transform rate metrics into numerator and counter metrics into denominator (as appropriate), but it turns out that it only provides to the Denominators the list of numerator names, not the list of numerators themselves.

We need the list of numerators so we can build CommonMetricData for them to construct the glean_core DenominatorMetric type.

I copypasta'd the code and made some inline edits in run_glean_parser.py.

This bug is for:

  • Changing glean_parser to provide the full information
  • Updating run_glean_parser.py to use the function provided by glean_parser
Whiteboard: [telemetry:glean-rs:m?]
Assignee: nobody → jrediger
Priority: P3 → P1
See Also: → 1768611
Attachment #9275835 - Attachment description: WIP: Bug 1720494 - Call glean_parser's `translate.transform_metrics` directly. r?chutten! → Bug 1720494 - Call glean_parser's `translate.transform_metrics` directly. r?chutten!
Pushed by jrediger@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3563af2280f8 Call glean_parser's `translate.transform_metrics` directly. r=chutten
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
See Also: → 1773671
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: