Closed Bug 1720515 Opened 4 years ago Closed 4 years ago

[linux, theme-specific] Menu Bar is unreadable in Firefox 90 (dark text on a dark background) with clearlooks-phenix gtk theme and builtin Firefox dark theme

Categories

(Firefox :: Menus, defect)

Product:
Firefox
Component:
Menus
Version:
Firefox 90
Platform:
x86_64
Linux
Type:
defect

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1720441

People

(Reporter: allo, Unassigned)

References

Details

(Keywords: regression, regressionwindow-wanted, steps-wanted)

The text in the menu bar in Firefox 90 does not follow the theme anymore, but is black.

Steps to reproduce:

  • Install Firefox 89
  • Enable the menu bar
  • Use the dark theme
  • Verify that the menu bar has white text
  • Upgrade to Firefox 90
  • See that the menu bar has black text on a dark background

Expected result:
The text color should come from the theme (and be white)

Observed result:
The text color is black

I could not reproduce this issue in latest Nightly 92.0a1 and release 90 under Ubuntu 18.04 64-bit and Win 10 64-bit.
Are you using some specific Linux theme? Also, is it reproducible with a clean profile? Thank you!

Flags: needinfo?(allo)

I can reproduce with a fresh profile and the official dark theme.. Firefox is installed from an mozilla.org tar.bz2 in an app dir and upgraded using the built-in update function for a few releases.

Maybe relevant: The Gtk-Theme is clearlooks-phenix. Maybe it is defining some font colors, which are (no longer) overwritten by Firefox when using dark themes?

Flags: needinfo?(allo)

I wonder if this is a regression from bug 1710643?

Flags: needinfo?(emilio)
Keywords: regression, regressionwindow-wanted, steps-wanted
Summary: Menu Bar has the wrong text color in Firefox 90 → [linux, theme-specific] Menu Bar is unreadable in Firefox 90 (dark text on a dark background) with clearlooks-phenix theme

What happens if you use the Firefox light theme?

Flags: needinfo?(allo)
Summary: [linux, theme-specific] Menu Bar is unreadable in Firefox 90 (dark text on a dark background) with clearlooks-phenix theme → [linux, theme-specific] Menu Bar is unreadable in Firefox 90 (dark text on a dark background) with clearlooks-phenix gtk theme and builtin Firefox dark theme
QA Whiteboard: [qa-regression-triage]

With the light theme the text is black as well.

Flags: needinfo?(allo)

I'm almost sure this is bug 1720441. I just queued that for landing, so next nightly should fix this.

Flags: needinfo?(emilio)

I couldn't reproduce on Firefox 90 with several GTK themes such as Adwaita-dark, Clearlooks-Phenix, Ambiance.

Alex, could you please try to run mozregression to see exactly which bug regressed this? Thank you!

QA Whiteboard: [qa-regression-triage]
Flags: needinfo?(allo)
See Also: → 1720247

@phorea: I'll try later (maybe after the weekend) if @emilio is right that the next nightly already fixes it. Otherwise I'll have a look at mozregression.

Depends on: 1720441
QA Whiteboard: [qa-regression-triage]

Works for me with nightly/2021/07/2021-07-20-09-46-04-mozilla-central/firefox-92.0a1.en-US.linux-x86_64.tar.bz2

Flags: needinfo?(allo)

Duping over per comment #9 / comment 6. Thanks!

Status: UNCONFIRMED → RESOLVED
Closed: 4 years ago
No longer depends on: 1720441
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.