1720648 - Update neqo to V0.4.28

Status: RESOLVED FIXED

(Core :: Networking: HTTP, task, P2)

Comment 1

[Kershaw Chang [:kershaw]]

Attachment: Bug 1720648 - Neqo v0.4.28, r=#necko

Comment 2

[Kershaw Chang [:kershaw]]

Attachment: Bug 1720648 - Make necko work with neqo 0.4.28, r=#necko

Depends on D119990

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bef07e680e80
Neqo v0.4.28, r=nhnt11
https://hg.mozilla.org/integration/autoland/rev/0c898d1889db
Make necko work with neqo 0.4.28, r=nhnt11

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/bef07e680e80
https://hg.mozilla.org/mozilla-central/rev/0c898d1889db

Comment 5

[Kershaw Chang [:kershaw]]

Comment on attachment 9231382 [details]
Bug 1720648 - Make necko work with neqo 0.4.28, r=#necko

Beta/Release Uplift Approval Request

• User impact if declined: Could cause the crash in bug 1720558.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): See https://github.com/mozilla/neqo/pull/1180. The change to fix the crash is straightforward and should not cause any regression.
• String changes made/needed: N/A

Comment 6

[Pascal Chevrel:pascalc (PTO until April 26)]

Kershaw, your patch does not graft cleanly to beta as it is on top of bug 1654507 which landed in 92, could you provide a rebased patch please? Thanks

Comment 7

[Kershaw Chang [:kershaw]]

Attachment: Bug 1720648 - For beta uplift, r=#necko

Comment 8

[Kershaw Chang [:kershaw]]

I've created D120074 that squashes the patches in bug 1654507 and patches in this bug. I think it's fine to also uplift bug 1654507, since the feature (ECH) is not enabled at all. It should not cause any regression.

Comment 9

[Kershaw Chang [:kershaw]]

Pascal, please let me know what do you think about uplifting bug 1654507 together or you prefer me to create a patch without bug 1654507. Thanks.

Comment 10

[Pascal Chevrel:pascalc (PTO until April 26)]

Kershaw, I would prefer a more isolated patch for uplift without having to uplift bug 1654507.

Comment 11

[Kershaw Chang [:kershaw]]

(In reply to Pascal Chevrel:pascalc from comment #10)

Kershaw, I would prefer a more isolated patch for uplift without having to uplift bug 1654507.

Ok, will do.

Comment 12

[Kershaw Chang [:kershaw]]

Attachment: Bug 1720648 - Rebased patch for beta uplift, r=#necko

Comment 13

[Kershaw Chang [:kershaw]]

A new rebased patch is created.
https://phabricator.services.mozilla.com/D120079

Comment 14

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9231597 [details]
Bug 1720648 - Rebased patch for beta uplift, r=#necko

Fix for top crash in bug D120079, approved for uplift in 91.0b5, thanks.

Comment 15

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-beta/rev/ab3ce9974176