Closed Bug 1720700 Opened 3 years ago Closed 2 years ago

46.2 - 9.47% Heap Unclassified / Explicit Memory (Linux) regression on Tue July 13 2021

Categories

(Core :: Graphics: WebRender, defect)

defect

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: bacasandrei, Unassigned)

References

(Regression)

Details

(Keywords: perf, perf-alert, regression)

Perfherder has detected a awsy performance regression from push 28c7b58df8e4d6f8cd4914b197031db988dc76ea. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio Suite Test Platform Options Absolute values (old vs new)
46% Heap Unclassified linux1804-64-shippable-qr tp6 231,814,008.16 -> 338,912,887.62
9% Explicit Memory linux1804-64-shippable-qr tp6 836,036,683.85 -> 915,190,955.34

Improvements:

Ratio Suite Test Platform Options Absolute values (old vs new)
30% JS linux1804-64-shippable-qr tp6 271,265,538.87 -> 190,257,679.78
26% JS linux1804-64-shippable-qr tp6 273,468,026.00 -> 202,412,108.68

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) will be backed out in accordance with our regression policy.

For more information on performance sheriffing please see our FAQ.

Flags: needinfo?(gwatson)

I won't have time to investigate this week, so I've asked for the patch to be backed out for now - it's only a very small patch so it should be easy to back out and re-land once I have investigated the regression.

Flags: needinfo?(gwatson)

Backing out the patch has caused the following alert:

== Change summary for alert #30593 (as of Sun, 18 Jul 2021 12:42:22 GMT) ==

Regressions:

Ratio Suite Test Platform Options Absolute values (old vs new)
35% JS linux1804-64-shippable-qr tp6 197,417,924.41 -> 266,609,528.84

Improvements:

Ratio Suite Test Platform Options Absolute values (old vs new)
32% Heap Unclassified linux1804-64-shippable-qr tp6 338,322,883.66 -> 230,045,140.37
11% Explicit Memory linux1804-64-shippable-qr tp6 917,484,348.49 -> 817,752,613.79
9% Resident Memory linux1804-64-shippable-qr tp6 1,318,352,590.73 -> 1,202,777,492.24

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=30593

Has Regression Range: --- → yes

Patch was backed out, and the full raster roots implementation landed some time ago.

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.