1720702 - Use Contile provided images for sponsored TopSites

Status: VERIFIED FIXED

(Firefox :: Top Sites, enhancement)

Description

[Nan Jiang [:nanj]]

JIRA ticket: FIDE-585

Sponsored TopSites are currently using the built-in Tippytop images, which are not easy for us and our partners to add & update. This feature allows sponsored top sites to use Contile provided images so that we and our partners are able to update them at any time.

Under the hood, Contile will copy all the images provided by partners to the Mozilla-hosted image base (CDN-backed & multi-regional), so sponsored top sites will never directly talk to 3rd party for the images.

Comment 1

[Nan Jiang [:nanj]]

I made a WIP patch for this, will add some tests and then submit for review.

Comment 2

[Nan Jiang [:nanj]]

Attachment: Bug 1720702 - Use Contile provided images for sponsored tiles r=amy,dao

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/db260f2962f4
Use Contile provided images for sponsored tiles r=amy,dao

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/db260f2962f4

Comment 6

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this issue on the latest Nightly 92.0a1 (Build ID: 20210723093620) using a mock-server created by Nan. The images are correctly displayed and visible for the Sponsored Top Sites. I have verified this on Windows 10 x64, macOS 10.15.7 and Lixnu Mint 20.

Considering the fact that I have verified this on a mock-server, I will re-verify this in production as soon as it is available to make sure that everything works as expected.

Comment 7

[Nan Jiang [:nanj]]

[Tracking Requested - why for this release]: This allows us to remotely update the icons for sponsored TopSites without riding the release train.

Comment 8

[Nan Jiang [:nanj]]

Comment on attachment 9231436 [details]
Bug 1720702 - Use Contile provided images for sponsored tiles r=amy,dao

Beta/Release Uplift Approval Request

• User impact if declined: If our partner wants to update icons for sponsored topsites, we'd have to land new images to the codebase and ask for uplifts, which is much more expensive and time-consuming than the remote updates.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is an optimization for sponsored TopSites. Also, if the backend (Contile) doesn't provide the remote images, Firefox would fall back to the built-in images.
• String changes made/needed: None

Comment 9

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9231436 [details]
Bug 1720702 - Use Contile provided images for sponsored tiles r=amy,dao

Approved for 91 beta 7, thanks.

Comment 10

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-beta/rev/a739636de124

Comment 11

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this issue on the latest Beta 91.0b7 (Build ID: 20210725190237) using the mock-server created by Nan. The images are correctly displayed and visible for the Sponsored Top Sites. I have verified this on Windows 10 x64, macOS 10.15.7 and Lixnu Mint 20.

Comment 12

[Cosmin Muntean [:cmuntean], Ecosystem QA]

This feature was pushed to Contile stage server. Considering this I have verified this feature on the staging server on Firefox 91.0 RC (Build ID: 20210802144751) and the latest Nightly 92.0a1 (Build ID: 20210805163446) on Windows 10 x64, macOS 10.15.7, and Linux Mint 20.

• The images are correctly displayed and visible for the Sponsored Top Sites.