Closed Bug 1720745 Opened 1 year ago Closed 11 months ago

[wpt-sync] Sync PR 29679 - Update navigator.ink.requestPresenter() to use a dictionary param

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox92 fixed)

RESOLVED FIXED
92 Branch
Tracking Status
firefox92 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29679 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29679
Details from upstream follow.

b'Mario Bianucci <mabian@microsoft.com>' wrote:

Update navigator.ink.requestPresenter() to use a dictionary param

requestPresenter took in two params, a String |type| and an Element
|presentationArea|. The goal of the |type| param was to enable
requestPresenter() to be easily extensible in the future for other types
of presenters.

However, in its current state, it is a no-op param. For this reason,
after some discussion (1, 2, 3) it has been decided that the API
should be updated to instead just use a dictionary param. This will
still be easily extensible in the future, but won't require a string
param until then.

Bug: 1052145
Change-Id: I9ef18a04ab150fff8c8f173bfa209e10d90781f3
Reviewed-on: https://chromium-review.googlesource.com/3027884
WPT-Export-Revision: cd7328cf2e1a942fd0419995189381e46f113158

CI Results

Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests and 6 subtests

Status Summary

Firefox

OK : 3
FAIL : 11
ERROR: 1

Chrome

OK : 3
PASS : 2
FAIL : 9
ERROR: 1

Safari

OK : 3
FAIL : 11
ERROR: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/delegated-ink/exception-thrown-bad-color.tentative.html
exception-thrown-bad-color: FAIL (Chrome: FAIL, Safari: FAIL)
/delegated-ink/exception-thrown-diameter-less-than-or-equal-to-0.tentative.html
exception-thrown-diameter-less-than-or-equal-to-0: FAIL (Chrome: FAIL, Safari: FAIL)
exception-thrown-diameter-less-than-or-equal-to-0 1: FAIL (Chrome: FAIL, Safari: FAIL)
exception-thrown-diameter-less-than-or-equal-to-0 2: FAIL (Chrome: FAIL, Safari: FAIL)
exception-thrown-diameter-less-than-or-equal-to-0 3: FAIL (Chrome: FAIL, Safari: FAIL)
/delegated-ink/exception-thrown-untrusted-event.tentative.window.html: ERROR (Chrome: ERROR, Safari: ERROR)
/delegated-ink/requestPresenter-returns-valid-promise.tentative.window.html
navigator needs to support ink to run this test.: FAIL (Chrome: PASS, Safari: FAIL)
Receive rejected promise for an invalid param.: FAIL (Chrome: PASS, Safari: FAIL)
Received fulfilled promise for no param: FAIL (Chrome: FAIL, Safari: FAIL)
Received fulfilled promise for null param: FAIL (Chrome: FAIL, Safari: FAIL)
Received fulfilled promise for empty dictionary param: FAIL (Chrome: FAIL, Safari: FAIL)
Received fulfilled promise for dictionary param with valid element.: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b6444ae3b823
[wpt PR 29679] - Update navigator.ink.requestPresenter() to use a dictionary param, a=testonly
https://hg.mozilla.org/integration/autoland/rev/4f1ebe2a6faf
[wpt PR 29679] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c16e87e23d97
[wpt PR 29679] - Update navigator.ink.requestPresenter() to use a dictionary param, a=testonly
https://hg.mozilla.org/integration/autoland/rev/a5fd1dd5dc96
[wpt PR 29679] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
You need to log in before you can comment on or make changes to this bug.