1720751 - No Thunderbird Daily build updates since 92.0a1

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Rob Lemley [:rjl]]

Bug 1720108 introduced a regression that is causing two builds to happen on the Daily pushes, and neither one makes it to the FTP server or Balrog.

Comment 1

[Rob Lemley [:rjl]]

Attachment: Bug 1720751 - Create a target_tasks_method for comm-central rather than using "default". r=justdave

Comment 2

[Rob Lemley [:rjl]]

Attachment: Bug 1720751 - Do not overwrite existing decision task parameters with project defaults. r=justdave

The Nightly Thunderbird builds are triggered by .cron.yml, which sets the value
of "target_tasks_method" to "nightly_desktop". That happens before the defaults
from PER_PROJECT_PARAMETERS are applied though, so it was getting overwritten.
As a result, none of the L10n, Beetmover, or Balrog jobs that are normally run
for a Daily build were not run.

Depends on D120004

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f13fb1158221
Create a target_tasks_method for comm-central rather than using "default". r=justdave
https://hg.mozilla.org/comm-central/rev/3fcd80b46916
Do not overwrite existing decision task parameters with project defaults. r=justdave

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1f42bccc2c04
Follow-up: If a parameter value is falsy, allow setting it. rs=bustage-fix

Comment 5

[Rob Lemley [:rjl]]

Comment on attachment 9231409 [details]
Bug 1720751 - Create a target_tasks_method for comm-central rather than using "default". r=justdave

[Approval Request Comment]
Regression caused by (bug #): 1720108
Build related fix, no user impact

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9231409 [details]
Bug 1720751 - Create a target_tasks_method for comm-central rather than using "default". r=justdave

[Triage Comment]
Approved for beta

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 91.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/1e26fc9b2ad6
https://hg.mozilla.org/releases/comm-beta/rev/4671eb71ebb6
https://hg.mozilla.org/releases/comm-beta/rev/e0842113ff75