1720836 - Search bar/address bar arrows do not have hover highlights and paddings are wrong

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Fanolian]

Attachment: Searchbar arrow.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:92.0) Gecko/20100101 Firefox/92.0
Build ID: 20210715215249

Steps to reproduce

1. In a new profile, add search bar to toolbar.
2. Type a long string of text in search bar so the text overflows.
3. Observe the "Submit search" button.

Actual result

1. Not enough paddings on both left and right of the arrow.
2. Hover highlight is gone.

Notes

It affects all 3 densities (Compact, Normal, Touch).

Regression

Last good Nightly: 2021-07-12
First bad Nightly: 2021-07-13
pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=3880d0d21aa306cfac44ea0d0fa188b59ae4233c&tochange=e3fb9f4b3db8772e54636c30426bbbd911deb8ad

Bisecting autoland builds:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=84b2f87384d5778fcd01fee192b91b156351a088&tochange=8b7dd99cdee2efb5c8a498a07a6c8d466395fd0d

This is regressed by bug 1706479, specifically the change D114642 according to the date:
https://phabricator.services.mozilla.com/D114642

Comment 1

[Fanolian]

Attachment: Address bar arrow

The arrow button in address bar is also affected.

Comment 2

[Fanolian]

The arrow in address bar is also affected.

Comment 3

[Jeronimo Torti (Please send NI request to Brindusa Tot)]

Hi Fanolian,
Thanks for submitting this bug report. I was able to reproduce the issue on Windows 10, on Firefox Nightly 92.0a1 (2021-07-20) (64-bit) version, but not in Release 90.0.1 (64-bit) versions.
I'll mark this as New for visibility.

I've assigned a component in order to get the dev team involved.
'Firefox-Address bar' team: if the component is not relevant please change it to a more appropriate one.

Regards,
Jerónimo.

Comment 4

[Marco Bonardo [:mak]]

Harry, could you please check what happened with that fix?

Comment 5

[Harry Twyford]

Attachment: Bug 1720836 - Restore Go button appearance by partially reverting D114642. r?dao!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/63666019e518
Restore Go button appearance by partially reverting D114642. r=desktop-theme-reviewers,dao

Comment 7

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/63666019e518

Comment 8

[Giorgia Nichita, Release Desktop QA]

I've reproduced this issue on Windows 10x64, using an affected Nightly version 92.0a1 (2021-07-16).
Verified fixed with Firefox 92.0b2 (20210810185524) on Windows 10x64, macOS 10.13 and Ubuntu 20.04.