1720874 - Transparent context menu with minwaita theme

Status: VERIFIED FIXED

(Core :: Widget: Gtk, defect)

Description

[antheo.lerouzic]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:89.0) Gecko/20100101 Firefox/89.0

Steps to reproduce:

Open a context menu (right click) on firefox 90 or later with "gfx.webrender.compositor.force-enabled" on true

Actual results:

The menu is transparent, like in this picture : https://www.casimages.com/i/210716014609220532.png.html

Expected results:

The context menu should not been transparent.

Comment 1

[antheo.lerouzic]

The problem is still here on the actual nightly.
Here is a link of my about:support : https://pastebin.com/Z1mL80jx

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Graphics: WebRender' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 3

[Dzmitry Malyshau [:kvark]]

Thank you for filing and attaching the about:support!
IIRC, context menus are rendered with software WR. So the issue is either that the output of rendering contains alpha of full transparency, we we don't expect it, or that the alpha compositing mode on the surface (responsible for the context menu) is configured incorrectly, which is more likely what's happening.
Lee, is that reasoning sound? Pinging you since you are involved in the sw-wr.

Comment 4

[Lee Salzman [:lsalzman]]

Does the problem only happen if you use the force-enabled pref? Are you using X11, or are you using Wayland?

Comment 5

[Robert Mader [:rmader]]

From the description and comment 1 this appears to happen with the experimental Wayland compositor backend.

antheo, you seem to have quite a few experimental features enabled. Could you try running with a fresh profile and only gfx.webrender.compositor.force-enabled? And do I understand correctly that the issue only happens with gfx.webrender.compositor.force-enabled?

Comment 6

[antheo.lerouzic]

Hi,
I use wayland, and the problem is still here with a fresh new profile, so it's not gfx.webrender.compositor.force-enabled related, sorry.
Thanks for your help!

Comment 7

[Robert Mader [:rmader]]

Thanks, that's good to know. Do you maybe happen to use a non-standard gtk theme? I recall having seen similar bugs when people do that.

Comment 8

[antheo.lerouzic]

Yes, I was using a non-official theme!
It worked great in 89 though, do you think there is a chance that it will work in future version or do I have to change my theme?
Thanks a lot for your help

Comment 9

[Robert Mader [:rmader]]

(In reply to antheo.lerouzic from comment #8)

Yes, I was using a non-official theme!
It worked great in 89 though, do you think there is a chance that it will work in future version or do I have to change my theme?
Thanks a lot for your help

Emilio, do you have an idea here?

Comment 10

[Emilio Cobos Álvarez (:emilio)]

I mean, a transparent context-menu is always a bug, so we should fix it, yeah.

Which gtk theme are you using?

Also, does it work on Nightly? This reminds me of bug 1709719, but it was fixed on time for 90 so...

Comment 11

[antheo.lerouzic]

I was using Minwaita, the bug was still here with nightly.
Thanks

Comment 12

[Emilio Cobos Álvarez (:emilio)]

Alright, will take a look, thanks!

To be clear with other gtk themes this is not an issue, is that right?

Comment 13

[antheo.lerouzic]

It's not an issue with White-sur theme, but maybe other gtk theme have the same problem.

Comment 14

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1720874 - Try to find menupopup background with :backdrop pseudo-class. r=stransky

This theme only styles menus with menu:backdrop (which always seems to
match for context menus).

Try that before giving up. Also, fall back to the window background if
that would ever fail (which seems better than just rendering
transparent).

Comment 15

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9231873 [details]
Bug 1720874 - Try to find menupopup background with :backdrop pseudo-class. r=stransky

Beta/Release Uplift Approval Request

• User impact if declined: Transparent context menus with some GTK themes.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Install Minwaita theme from https://github.com/godlyranchdressing/Minwaita. Right click anywhere.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple fallback rather than ending up with a transparent color.
• String changes made/needed: none

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0f7a29399878
Try to find menupopup background with :backdrop pseudo-class. r=stransky

Comment 17

[jjensen625]

I am running a GTK 2.0/3.0 theme under MATE on Arch, and I started noticing this as well with the 90.0 update. (The theme in question is called "Platinum" and is designed to emulate the look of classic Mac OS.) I was wondering if my theme got corrupted or something, but I stumbled across this bug report. I'm glad I did, because I was just looking at the resource files to figure out what happened.

Comment 18

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/0f7a29399878

Comment 19

[Pascal Chevrel:pascalc]

Comment on attachment 9231873 [details]
Bug 1720874 - Try to find menupopup background with :backdrop pseudo-class. r=stransky

Looks low risk, approved for 91 beta 5, thanks.

Comment 20

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9231873 [details]
Bug 1720874 - Try to find menupopup background with :backdrop pseudo-class. r=stransky

Beta/Release Uplift Approval Request

• User impact if declined: Transparent context menus with some gtk themes.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: see above
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): More fallback colors.
• String changes made/needed: none

Comment 21

[Emilio Cobos Álvarez (:emilio)]

(If we do a dot-release, this patch might be worth pulling in)

Comment 22

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/33952cdec057

Comment 23

[Julien Cristau [:jcristau]]

Comment on attachment 9231873 [details]
Bug 1720874 - Try to find menupopup background with :backdrop pseudo-class. r=stransky

approved for 90.0.2

Comment 24

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-release/rev/3d2ddaa563e7

Comment 25

[Anca Soncutean, Desktop QA]

Reproduced with Fx 90.0 and Fx 91.0b4 on Ubuntu 18.04.
Verified fixed with Fx 92.0a1 (21-06-2021), Fx 91.0b5 and Fx 90.0.2 on Ubuntu 18.04.