1720880 - [macOS] Corners of bookmarks toolbar menu button submenus are not rounded

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect, P3)

Description

[:Gijs (he/him)]

See last few comments in bug 1710556. Not sure what's going on, I'll update this bug as I find out.

Comment 1

[:Gijs (he/him)]

Emilio, looks like bug 1716546 broke this - can you take a look?

Comment 2

[:Gijs (he/him)]

(I stopped in mozregression when I got to https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=67ab2380add19fc87ace78dcd7e719e8b6491ce3&tochange=3a5827b23ccc2b9e5f703f3a36b27dad593ab991 )

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Sure

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1720880 - Remove :-moz-lwtheme from a bookmarks popup-specific selector. r=Gijs

With the system theme otherwise we show square corners.

Also remove a margin rule which other menupopups don't have and which feels a
bit ugly, but let me know if you want that one back (without the :-moz-lwtheme
selector).

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1720880 - Consolidate a bit bookmarks popup styles. r=dao

Unify shared declarations, and avoid unneeded [placespopup=true], since
there's no element that matches:

:is(#BMB_bookmarksPopup, #PlacesToolbar) menupopup:not([placespopup])

Depends on D120080

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9bea31d80fad
Remove :-moz-lwtheme from a bookmarks popup-specific selector. r=Gijs,desktop-theme-reviewers,dao
https://hg.mozilla.org/integration/autoland/rev/ef58d79c5818
Consolidate a bit bookmarks popup styles. r=dao

Comment 7

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/9bea31d80fad
https://hg.mozilla.org/mozilla-central/rev/ef58d79c5818

Comment 8

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

I have reproduced this issue using Firefox 91.0b3 on macOS 10.15.
I can confirm this issue is fixed, I verified using Firefox 92.0b2 macOS 10.15.