1720900 - Use the Proton button and focus styling for the Chat status button

Status: RESOLVED FIXED

(Thunderbird :: Theme, task)

Description

[Richard Marti (:Paenglab)]

When you open the chat tab with no connected server a screen is shown with the text: "Your chat accounts are not connected" and a button below. This button can be better styled.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1720900-chat-status-button-focus.patch

With this patch we use the standard colour defined for Proton. Also the focus is Proton like.

Comment 2

[Alessandro Castellani [:aleca]]

Comment on attachment 9231579 [details] [diff] [review]
1720900-chat-status-button-focus.patch

Review of attachment 9231579 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.

::: mail/components/im/themes/chat.css
@@ +83,3 @@
>  }
>  
>  .im-placeholder-button-box> button:hover {

nit: missing space before >

@@ +87,3 @@
>  }
>  
> +.im-placeholder-button-box> button:hover:active {

same here

Comment 3

[Richard Marti (:Paenglab)]

Attachment: 1720900-chat-status-button-focus.patch

Fixed the review comments.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f1a332a49d21
Use the Proton button and focus styling for the Chat status button. r=aleca

Comment 5

[Richard Marti (:Paenglab)]

Comment on attachment 9231648 [details] [diff] [review]
1720900-chat-status-button-focus.patch

[Approval Request Comment]
User impact if declined: no Proton styling for the "Show chat status" button
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9231648 [details] [diff] [review]
1720900-chat-status-button-focus.patch

[Triage Comment]
Approved for beta

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 91.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/e15292d577b6