1720931 - moz-phab 1.0.0rc1 is leaking changes between revisions in stack

Status: RESOLVED FIXED

(Conduit :: moz-phab, defect, P2)

Description

[Mitchell Hentges [:mhentges] 🦀]

Attachment: revisions.txt

Some changes from my 2nd revision are appearing as part of my 1st revision on Phabricator.

See the first revision on Phabricator where all of ensure_python_modern() was removed, but it was just supposed to partly remove the function (like this).

Other notes:

• This doesn't happen with 0.1.99.
• This doesn't happen if I individually submit the patches with moz-phab -s.

Comment 1

[Mitchell Hentges [:mhentges] 🦀]

Attachment: revisions-2.txt

I've simplified the reproduce criteria a bit:

• The two revisions now only remove two functions - one per patch, each adjacent to each other
  • Revision 1 removes is_python_modern(): phabricator shows that it remove both functions
  • Revision 2 removes ensure_python_modern(): phabricator shows this correctly

Local hg show work looks like:

@  18304b2 Bug 1720925: [test] Move platform-specific Python upgrade instructions
o  33c7621 Bug 1720925: [test] Remove Python 2 warning from bootstrap
o  160071a (central) Bug 1720633 - Remove old "network.http.spdy.bug1563538" pref checks. r=necko-reviewers,kershaw

Comment 2

[Zeid Zabaneh [:zeid]]

Attachment: Bug 1720931: fix leaks between revisions within a stack r=sheehan

Some mercurial commands still rely on the repo being checked out in
order to generate the correct hunks for diffs when running the submit
command. This is a temporary fix that will result in the right
hunks/diffs being generated, until the rest of the code is refactored.

Comment 3

[Zeid Zabaneh [:zeid]]

Fix will be release with 1.0.0rc2