1720955 - Add-on "Hide Local Folders for TB78++" is not working correctly after TB restart [TB 91]: Uncaught (in promise) TypeError: requestedWindow.gFolderTreeView._tree is null

Status: RESOLVED INVALID

(Thunderbird :: Add-Ons: Extensions API, defect)

Description

[C-E]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:90.0) Gecko/20100101 Firefox/90.0

Steps to reproduce:

Install Add-on "Hide Local Folders for TB78++" in TB91 --> works correctly, i.e. all folders appear except 'Local Folders'.
Restart TB --> All folders disappear.
Deactivate "Hide Local Folders for TB78++" --> no effect, still no folders visible.
Restart TB --> all folders present.

Actual results:

See above

Expected results:

Install Add-on "Hide Local Folders for TB78++" in TB91.
Restart TB --> All folders should appear except 'Local Folders'.

Comment 1

[Thomas D. (:thomas8)]

I cannot reproduce this on 78.12.0 (64-bit), en-US.

• Are you using a localized version of TB?
• Can you try disabling any other addons?
• Any previous manipulation of folders and their order?

STR
S1. Install Add-on "Hide Local Folders for TB78+"
S2. Observe folder list
S3. Restart TB
S4. Observe folder list

Actual == Expected
@S2: Local folders hidden, any other folders shown after addon install (correct)
@S4: Local folders hidden, any other folders shown after restart TB with addon installed and active (correct)
Disabling/Re-enabling addon is effective immediately to show/hide local folders.

Comment 2

[Thomas D. (:thomas8)]

Confirming for TB BETA 91.0b1 (32-Bit), de-DE.
Note: Per TB's start page disclaimer, Add-ons are generally not guaranteed to work with TB Beta. I had to download and manually install the xpi.
There's a console error from the add-on code - most likely a bug in the add-on.

STR
S1. Install Add-on "Hide Local Folders for TB78+"
S2. Observe folder list
S3. Restart TB
S4. Observe folder list
S5. Disable add-on and observe folder list
S6. Restart

Actual
@S2: Local folders hidden, any other folders shown after addon install (correct)
(Until restart of TB, disabling/Re-enabling addon is effective immediately to show/hide local folders.)
@S4: Folder pane is empty after restart TB with addon installed and active (this bug, see screenshot in my next comment)
Console error seen (see below)
@S5: Folder pane is still empty when disabling Add-on after error
@S6: Folder pane restored after restart with add-on disabled (ok)

Uncaught (in promise) TypeError: requestedWindow.gFolderTreeView._tree is null
    cleanTree jar:file:///C:/Users/John/AppData/Roaming/Thunderbird/Profiles/xxxxxxxx.default-beta-1/extensions/[e-mail]!/implementation.js:35
    _rebuild jar:file:///C:/Users/John/AppData/Roaming/Thunderbird/Profiles/xxxxxxxx.default-beta-1/extensions/[e-mail]!/implementation.js:27
    load chrome://messenger/content/folderPane.js:200
implementation.js:35:25

Comment 3

[Thomas D. (:thomas8)]

Attachment: Screenshot 1: Empty folder pane after restart with add-on enabled (console error)

This is how it looks after the console error.

Comment 4

[John Bieling]

@C-E: You are doing stuff too early, the messenger / folder pane is not yet ready when your implementation code tries to modify it. I think you have to wait till the "mail-delayed-startup-finished" observer has fired.

This is better discussed on the add-on developer matrix chat or on topicbox, as this is not a bug in Thunderbird.

Edit: Add link to community channels:
https://developer.thunderbird.net/add-ons/community

Comment 5

[John Bieling]

Moved: https://thunderbird.topicbox.com/groups/addons/Te6bfda71fa553424