1721055 - Unify the IMIP button styling and synchronize it with the toolbarbuttons

Status: RESOLVED FIXED

(Calendar :: General, task)

Description

[Richard Marti (:Paenglab)]

Actually the hover appearance is different to the one we have for the toolbarbuttons on the main tool bar or the message header tool bar.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1721055-IMIP-unify-styling.patch

I moved the individual stylings to the shared file. In the individual files are only the platform dependent variable definitions.

Comment 2

[Alessandro Castellani [:aleca]]

Comment on attachment 9231748 [details] [diff] [review]
1721055-IMIP-unify-styling.patch

Review of attachment 9231748 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/09246bc25bae
Unify the IMIP button styling and synchronize it with the toolbarbuttons. r=aleca

Comment 4

[Richard Marti (:Paenglab)]

Comment on attachment 9231748 [details] [diff] [review]
1721055-IMIP-unify-styling.patch

[Approval Request Comment]
User impact if declined: less consistent appearance of the IMIP buttons near the message header buttons
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9231748 [details] [diff] [review]
1721055-IMIP-unify-styling.patch

[Triage Comment]
Approved for beta

Comment 6

[Dave Miller [:justdave]]

Thunderbird 910b3:
https://hg.mozilla.org/releases/comm-beta/rev/9d5debb643b0