Closed Bug 1721101 Opened 3 years ago Closed 3 years ago

Intermittent comm/mail/components/extensions/test/browser/browser_ext_contentScripts.js | backgroundColor - "rgb(0, 255, 0)" == "rgba(0, 0, 0, 0)" - got "rgb(0, 255, 0)", expected "rgba(0, 0, 0, 0)" (operator ==)

Categories

(Thunderbird :: Add-Ons: Extensions API, defect, P5)

Tracking

(thunderbird_esr91 unaffected, thunderbird91 fixed)

RESOLVED FIXED
92 Branch
Tracking Status
thunderbird_esr91 --- unaffected
thunderbird91 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: darktrojan)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

The test is wrong. It expects the lack of permissions to stop the script from running, but actually permissions don't do that, and the script usually isn't running because the page is loaded before the extension. Sometimes the page load happens after the extension load and the script runs (because it should), failing the test.

Assignee: nobody → geoff
Status: NEW → ASSIGNED

Also there's a second failure which I think is also caused by the extension loading before the page does. I don't actually understand why, it shouldn't be happening.

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/88e19d69c40a
Correct behaviour of test browser_ext_contentScripts.js. r=rnons

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch

Comment on attachment 9233228 [details]
Bug 1721101 - Correct behaviour of test browser_ext_contentScripts.js. r=rnons

[Approval Request Comment]
Low risk, only affects test code. This does show up on beta91 builds.

Attachment #9233228 - Flags: approval-comm-beta?

Comment on attachment 9233228 [details]
Bug 1721101 - Correct behaviour of test browser_ext_contentScripts.js. r=rnons

[Triage Comment]
Approved for beta

Attachment #9233228 - Flags: approval-comm-beta? → approval-comm-beta+

I didn't request uplift because I'm still seeing a problem similar to this one on comm-central. Not that I'm opposed to it being uplifted or anything. But there may be more.

Status: RESOLVED → REOPENED
Resolution: FIXED → ---

I suppose I should open a new bug instead since there was an uplift.

Status: REOPENED → RESOLVED
Closed: 3 years ago3 years ago
Resolution: --- → FIXED
See Also: → 1725898
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: