1721105 - The screenshots shortcut (Ctrl+Shift+S) does not take into account the zoomFactor

Status: VERIFIED FIXED

(Firefox :: Screenshots, defect)

Description

[Kajal Sah]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/91.0.4472.101 Safari/537.36

Steps to reproduce:

1. Open any webpage
2. Zoom in (Ctrl +)
3. Take a screenshot with (Ctrl+Shift+S) and choose Full Page

Actual results:

The screenshot is cropped

Expected results:

The screenshot should match the case when its taken after choosing from the menu

Comment 1

[BugBot [:suhaib / :marco]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Screenshots' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Clara Guerrero ( Need Info Brindusa Tot Please)]

Attachment: Screenshot 2021-07-19 at 12-31-54 Firefox Nightly First Run Page.png

Comment 3

[Clara Guerrero ( Need Info Brindusa Tot Please)]

Hi,
Thank you for taking the time to submit this bug report. I was able to reproduce on ubuntu 20.04, on the following versions

Firefox Nightly version firefox-92.0a1
Beta 91.0b4
Release 90.0.1

A component has been assigned in order to get the dev team involved, but if it's not relevant, please feel free to change it to an appropriate one.
Best regards,
Clara

Comment 4

[Emma Malysz]

Attachment: Bug 1721105, use zoom factor for screenshots shortcut

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f8a77ad96a91
use zoom factor for screenshots shortcut r=sfoster

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/f8a77ad96a91

Comment 7

[Pascal Chevrel (relman team) -> :pascalc|PTO until Sept 2]

Emma, that looks like an easy to hit bug and the patch is small, would it be safe to uplift that fix to beta? Thanks

Comment 8

[Emma Malysz]

Comment on attachment 9231987 [details]
Bug 1721105, use zoom factor for screenshots shortcut

Beta/Release Uplift Approval Request

• User impact if declined: If the page is zoomed, the screenshot will be cropped if brought up from the screenshots shortcut
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): No strings
• String changes made/needed: n/a

Comment 9

[Pascal Chevrel (relman team) -> :pascalc|PTO until Sept 2]

Comment on attachment 9231987 [details]
Bug 1721105, use zoom factor for screenshots shortcut

Approved for 91 beta 7, thanks.

Comment 10

[Pascal Chevrel (relman team) -> :pascalc|PTO until Sept 2]

https://hg.mozilla.org/releases/mozilla-beta/rev/28edc8235828

Comment 11

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Reproduced the issue on Firefox 92.0a1 (2021-07-18) under macOS 10.15.

The issue is fixed on Firefox 91.0b7 and Firefox 92.0a1 (2021-07-25). Tests were performed on macOS 10.15, Ubuntu 20.04 and Windows 10.