1721161 - The Debugger tab should be properly unhighlighted when pausing and resuming XHR BReakpoints

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Description

[Hubert Boma Manilla (:bomsy)]

STR

1. Go to https://www.google.com/
2. Open the debugger
3. Check "Pause on any URL" in the XHR Breakpoints section
4. Reload the page
5. After the page pauses
6. Click resume

AR
The debugger panel tab is still highlighted.

ER
The debugger panel tab should not be highlighted.

Comment 1

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1721161 - [devtools] Fix debugger highlight on pause/resume xhr breakpoints

Comment 2

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1721161 - [devtools] test commit

Comment 3

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1721161 - [devtools] Fix debugger highlight on pause/resume xhr breakpoints r=jdescottes

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6a96e55759fa
[devtools] Fix debugger highlight on pause/resume xhr breakpoints r=jdescottes

Comment 5

[Natalia Csoregi [:nataliaCs]]

Backed out for failures on browser_dbg-xhr-breakpoints.js

• backout: https://hg.mozilla.org/integration/autoland/rev/56592956caa1fc1f3c0758c64d3508b2d153003f

• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=6a96e55759fa7876a73c222a23cd691362bf462b

• tier 1 failure occurrence: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=A_tc3kFDQ764B5DLvdqwtQ.0&revision=325375c2d4cfb39f0572ee93078bd806d5fa0c5c&searchStr=os%2Cx%2C10.15%2Cwebrender%2Copt%2Cmochitests%2Ctest-macosx1015-64-qr%2Fopt-mochitest-devtools-chrome-e10s%2Cdt4

• failure log: https://treeherder.mozilla.org/logviewer?job_id=346483739&repo=autoland&lineNumber=3190

[task 2021-07-27T15:48:41.254Z] 15:48:41     INFO - TEST-PASS | devtools/client/debugger/test/mochitest/browser_dbg-xhr-breakpoints.js | Debugger is no longer highlighted after resume - 
[task 2021-07-27T15:48:41.254Z] 15:48:41     INFO - Invoking in tab: main("fetch.js")
[task 2021-07-27T15:48:41.255Z] 15:48:41     INFO - Waiting for state change: paused
[task 2021-07-27T15:48:41.255Z] 15:48:41     INFO - Buffered messages logged at 15:48:41
[task 2021-07-27T15:48:41.255Z] 15:48:41     INFO - Finished waiting for state change: paused
[task 2021-07-27T15:48:41.256Z] 15:48:41     INFO - Finished waiting for state change: paused
[task 2021-07-27T15:48:41.256Z] 15:48:41     INFO - Waiting for state change: fetched frames
[task 2021-07-27T15:48:41.256Z] 15:48:41     INFO - Finished waiting for state change: fetched frames
[task 2021-07-27T15:48:41.257Z] 15:48:41     INFO - Waiting for state change: selected source
[task 2021-07-27T15:48:41.257Z] 15:48:41     INFO - Finished waiting for state change: selected source
[task 2021-07-27T15:48:41.258Z] 15:48:41     INFO - Resuming from 4
[task 2021-07-27T15:48:41.258Z] 15:48:41     INFO - Waiting for state change: 
[task 2021-07-27T15:48:41.258Z] 15:48:41     INFO - Finished waiting for state change: 
[task 2021-07-27T15:48:41.259Z] 15:48:41     INFO - Buffered messages finished
[task 2021-07-27T15:48:41.260Z] 15:48:41     INFO - TEST-UNEXPECTED-FAIL | devtools/client/debugger/test/mochitest/browser_dbg-xhr-breakpoints.js | Debugger is no longer highlighted after resume - 
[task 2021-07-27T15:48:41.260Z] 15:48:41     INFO - Stack trace:
[task 2021-07-27T15:48:41.260Z] 15:48:41     INFO - chrome://mochikit/content/browser-test.js:test_ok:1343
[task 2021-07-27T15:48:41.260Z] 15:48:41     INFO - chrome://mochitests/content/browser/devtools/client/debugger/test/mochitest/browser_dbg-xhr-breakpoints.js:null:84
[task 2021-07-27T15:48:41.260Z] 15:48:41     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1098
[task 2021-07-27T15:48:41.260Z] 15:48:41     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1138
[task 2021-07-27T15:48:41.260Z] 15:48:41     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:946
[task 2021-07-27T15:48:41.260Z] 15:48:41     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1041
[task 2021-07-27T15:48:41.260Z] 15:48:41     INFO - Invoking in tab: main("README.md")

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b0c5ca442a12
[devtools] Fix debugger highlight on pause/resume xhr breakpoints r=jdescottes

Comment 7

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/b0c5ca442a12

Comment 8

[Oana Botisan, Desktop QA]

I can't seem to be able to reproduce the issue. Can you please check to see if the bug is still reproducing on latest beta?

Comment 9

[Hubert Boma Manilla (:bomsy)]

Apologies for the late reply. I confirmed it's fixed on 92.0b9 (latest BETA), but i see the issue on 91.0.2 (latest release)