1721255 - MediaKeys is missing NS_INTERFACE_MAP_ENTRY for nsISupports

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P1)

Description

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

This is essentially me doing bug 1571081 again. Footgunned myself by misunderstanding XPCOM interface macros. Having just an interface entry for nsIObserves does not imply nsISupports, we still need an nsISupports macro entry.

STR:

• Open a page with an EME video in a debug build.
• Inspect the video element in the dev tools and try to look at the MediaKeys attached to it.

Result:
Firefox asserts.

Comment 1

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Attachment: Bug 1721255 - Restore NS_INTERFACE_MAP_ENTRY(nsISupports) to MediaKeys. r?alwu

I mistakenly removed this line, but it's needed to avoid issues.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2d72dd22f419
Restore NS_INTERFACE_MAP_ENTRY(nsISupports) to MediaKeys. r=alwu

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/2d72dd22f419

Comment 5

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

This issue is an annoyance for debugging. It wouldn't be the end of the world if this isn't uplifted, but it would be nice not to have in the next ESR, so I plan to request uplift.

Comment 6

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Comment on attachment 9232009 [details]
Bug 1721255 - Restore NS_INTERFACE_MAP_ENTRY(nsISupports) to MediaKeys. r?alwu

Beta/Release Uplift Approval Request

• User impact if declined: A fatal assert happens in debug builds when inspecting MediaElements playing DRM content using dev tools. This won't impact normal users, but is a big pain for developers debugging media DRM with the dev tools.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Not risky as the change is small (a single line) that fixes XPCOM macro usage.
• String changes made/needed: None

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: I'd like to avoid having having the bug baked into the new ESR for developer ergonomics. The would be a pain for folks debugging media DRM with the dev tools.
• User impact if declined: A fatal assert happens in debug builds when inspecting MediaElements playing DRM content using dev tools. This won't impact normal users, but is a big pain for developers debugging media DRM with the dev tools.
• Fix Landed on Version: 92
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Not risky as the change is small (a single line) that fixes XPCOM macro usage.
• String or UUID changes made by this patch: None.

Comment 7

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9232009 [details]
Bug 1721255 - Restore NS_INTERFACE_MAP_ENTRY(nsISupports) to MediaKeys. r?alwu

Approved for 91 beta 6, thanks.

Comment 8

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-beta/rev/68f7234fa31e

Comment 9

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9232009 [details]
Bug 1721255 - Restore NS_INTERFACE_MAP_ENTRY(nsISupports) to MediaKeys. r?alwu

I am removing the uplift request to esr 91 as we are syncing Firefox 91 and ESR 91 until the merge next week.