1721272 - Extension tabs ignore icons set by link tags

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, defect)

Description

[John Bieling (:TbSync)]

This is another fission bug. After it had been enabled, tabs from WebExtensions no longer show icons defined in link tags in their html source.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1721272 - Rename LinkHandler actor to LinkClickHandler. r=john.bieling

Firefox also has an actor named LinkHandler, and we're about to start using it. This patch renames our actor to avoid the naming clash.

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1721272 - Use LinkHandler actor from Firefox. r=john.bieling

The LinkHandler actor deals with page icons from remote processes. With this patch we'll use Firefox's child process actor and our own copy of the parent process actor, which is cut down and modified to do only what we need.

Depends on D120460

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d33c2830917d
Rename LinkHandler actor to LinkClickHandler. r=john.bieling
https://hg.mozilla.org/comm-central/rev/1c987c2918f3
Use LinkHandler actor from Firefox. r=john.bieling

Comment 4

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1721272 follow-up - Prevent tab icons being replaced by the default. r=john.bieling

I misunderstood why useDefaultIcon was being called despite an icon existing, and then I forgot to run the test I knew was most likely to fail.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1915aa19f592
follow-up - Prevent tab icons being replaced by the default. r=john.bieling

Comment 6

[John Bieling (:TbSync)]

Comment on attachment 9232342 [details]
Bug 1721272 - Rename LinkHandler actor to LinkClickHandler. r=john.bieling

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined:
No favicon displayed in tabs for WebExtension pages.

Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky):
Low

Comment 7

[John Bieling (:TbSync)]

Comment on attachment 9232343 [details]
Bug 1721272 - Use LinkHandler actor from Firefox. r=john.bieling

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined:
No favicon displayed in tabs for WebExtension pages.

Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky):
Low

Comment 8

[John Bieling (:TbSync)]

Comment on attachment 9232621 [details]
Bug 1721272 follow-up - Prevent tab icons being replaced by the default. r=john.bieling

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined:
No favicon displayed in tabs for WebExtension pages.

Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky):
Low

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9232342 [details]
Bug 1721272 - Rename LinkHandler actor to LinkClickHandler. r=john.bieling

[Triage Comment]
Approved for beta

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9232343 [details]
Bug 1721272 - Use LinkHandler actor from Firefox. r=john.bieling

[Triage Comment]
Approved for beta

Comment 11

[Wayne Mery (:wsmwk)]

Comment on attachment 9232621 [details]
Bug 1721272 follow-up - Prevent tab icons being replaced by the default. r=john.bieling

[Triage Comment]
Approved for beta

Comment 12

[Rob Lemley [:rjl]]

Thunderbird 91.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/3d53a197ed05
https://hg.mozilla.org/releases/comm-beta/rev/e82f4e947e73
https://hg.mozilla.org/releases/comm-beta/rev/4f02f53b56fc

Comment 13

[alta88]

This, I believe, has regressed tab icon behavior for folder and message tab types. It manifests most clearly for feeds: the folderpane favicon and tab favicon are taken from the feed folder url and should be identical regardless of message selected - this is true even if a feed web page with a different favicon is loaded into messagepane browser. In beta, loading a web page changes the 3pane tab favicon. Can be seen with a feed like https://planet.mozilla.org/atom.xml.

For a message in a tab, however, the tab favicon is derived from the web page.

Comment 14

[Geoff Lankow (:darktrojan)]

Okay, I can see that. Please file a separate bug.