Open Bug 1721331 Opened 4 years ago Updated 4 years ago

Add page to Pocket pop-up no longer auto-completes tags with Tab key

Categories

(Firefox :: Pocket, defect, P3)

Product:
Firefox
Component:
Pocket
Version:
Firefox 90
Type:
defect

Tracking

()

Tracking Flags:
Tracking Status
firefox90 --- affected
firefox91 --- affected
firefox92 --- affected

People

(Reporter: david.hellfeuer, Assigned: thecount)

Details

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:90.0) Gecko/20100101 Firefox/90.0

Steps to reproduce:

  1. Log in to Pocket account
  2. Save an arbitratry web page to Pocket (using either the button next to the search bar or the entry in the contect menu when right-clicking on a link)
  3. In the "Saved to Pocket" pop-up, click in the "Add tags" input field
  4. Start typing the first characters of an existing tag, e.g. "tec" as the first characters of existing tag "technology"
  5. Auto-complete list below the input field appears and shows full tag "technology"
  6. Press the Tab key

Actual results:

  1. New Pocket tag "tec" created
  2. Input cursor moved to after the new tag "tec" in the Pocket "Add tags" input field

Expected results:

  1. Existing Pocket tag "technology" filled into the input field
  2. Input cursor moved to after the tag "technology" in the Pocket "Add tags" input field

The Bugbug bot thinks this bug should belong to the 'Firefox::Pocket' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Component: Untriaged → Pocket

Reproduced this issue on all the latest Firefox versions on MacOS 10.15, can reproduce it back to Fx81 as well so not sure if this used to work as the expected results from the bug description. Thank you for this report!

Severity: -- → S3
Status: UNCONFIRMED → NEW
status-firefox90: --- → affected
status-firefox91: --- → affected
status-firefox92: --- → affected
Ever confirmed: true

I have an older version of Firefox still running on a different machine (version 89.0.2, 64-bit, Windows 8.1). I have reproduced the expected behavior and I have to slightly correct the steps to reproduce:

  1. Log in to Pocket account
  2. Save an arbitratry web page to Pocket (using either the button next to the search bar or the entry in the contect menu when right-clicking on a link)
  3. In the "Saved to Pocket" pop-up, click in the "Add tags" input field
  4. Start typing the first characters of an existing tag, e.g. "tec" as the first characters of existing tag "technology"
  5. Auto-complete list below the input field appears and shows full tag "technology"
    5.5. (new) Press the arrow down key as often as needed to select the desired tag from the auto-complete list
  6. Press the Tab key

With that correction, the expected behavior is as I remembered it, i.e. the typed text is expanded to the selected full tag and the input cursor moved to after the tag.

When I test this in ff92, when I hit tab, I get the full tag input, but the input cursor does not move to after the tag, which yeah, at the very least that feels like a bug.

I'll give ff90 a try and report back to see if it has issues inputting the whole tag or something else is wrong.

Assignee: nobody → sdowne

ff90 also inputted the whole tag, but arrow key navigation didn't work, which was fixed in 91 and 92.

So I think this bug is a matter of fixing that tab should keep focus in the input box.

Priority: -- → P3

Hi there, since upgrading to FF 91.0.2. (64-bit), both the auto-complete on tab (this bug) and the close on enter (bug #1721332) work again! I first noticed on my Windows 8.1 machine and then recreated it on my Windows 10 machine (checked behaviour before and after update). Was this a conscious fix or unintentional and a consequence of other changes?

It's likely bug 1720567 fixes both enter and tab key.

What I'm not so sure about is what fixed tab key keeping the cursor in the input, but yes that seems to be working again too.

You need to log in before you can comment on or make changes to this bug.