1721466 - The new redesigned Clear recent history window modal lacks title

Status: VERIFIED FIXED

(Toolkit Graveyard :: Notifications and Alerts, defect)

Description

[Greg-21]

Steps to reproduce:

1. Launch Firefox (it must be new enough to have the new redesigned Clear recent history window modal).
2. Click: Application menu > History > Clear recent history, or press Ctrl + Shift + Delete.
3. Look at the window modal that just appeared and see what is described in the "Actual results" section.

Actual results:

The new redesigned Clear recent history window modal lacks title. This is in contradiction to all the other existing window modals. Also, if someone accidentally opened this redesigned modal (Ctrl + Shift + Delete is not much different than Ctrl + Alt + Delete, which is the best-known shortcut for opening the Windows Task Manager), they might have no idea what it is for.

Unfortunately, since I don't have access to the Proton mockups by the Firefox Design Team (unlike the Photon ones, which were publicly available), I'm not sure if the lack of title is an intentional change or simply an oversight.

Expected results:

The new redesigned window modal should have a title. Just like the old one.

As before, I don't have access to mockups, so I don't know what the wording should be here, but the UX team probably knows.

Comment 1

[Greg-21]

Attachment: New_clear_recent_history_lacks_title.png

Comment 2

[Greg-21]

Attachment: Old_clear_recent_history_has_title.png

Comment 3

[:Gijs (he/him)]

Attachment: Bug 1721466 - add title to clear recent history dialog when opened as a subdialog in the browser window, r?mconley

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a4f7c2f0c315
add title to clear recent history dialog when opened as a subdialog in the browser window, r=mconley

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/a4f7c2f0c315

Comment 6

[Giorgia Nichita, Release Desktop QA]

I've reproduced this issue on Windows 10x64, using an affected Nightly version 92.0a1 (2021-07-20).
Verified fixed with Firefox 92.0b2 (20210810185524) on Windows 10x64, macOS 10.13 and Ubuntu 20.04.