172147 - URL in composition "decoration" continues on next line

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect)

Description

[Mark Townsend]

While in the mail composition window after doing a 'Send Link...', if you move
the cursor to the end of the message (the end of the line with the link in it),
and hit return to go to the next line, the decoration for the link continues
when you are typing new information.

To get around this, if you go to the end of the line and hit the space bar
before hitting return, then all is ok.

Comment 1

[Jean-Francois Ducarroz]

I can confirm the problem, this is very annoying.
Accepting the bug unless Varada has some free cycle to work on it...

Comment 2

[esther]

Note: in trunk build 20021001, hitting space bar before enter doesn't release
the decoration.  I have to select the unwanted link and use the menu iteme to
remove link. Not sure what build this was reported against, but is seems worse
in the trunk.

Comment 3

[Kathleen :Brade]

This sounds like it may be a bug for jfrancis

Comment 4

[Kevin McCluskey (gone)]

EDITORBASE+.
-> Joe

Comment 5

[Joe Francis]

This is actually the result of a selection bug fix (I forget the bug#) where
mjudge (at my request) changed selection so that when you click after the end of
a line, the selection end up inside the inline styles at teh end of that line,
rather than after them.  For anything but a link, this is what users seem to
expect.  Not sure what I can do about clickng at the end of the link and then
typing text: I can't realy tell that you didn't mean to extend the link text. 
But I can fix it for typing return.  People almost never want to make a link
with a <br> in it, and if they really want to they can use shift-return, which
skips any special return logic we have and just puts in a <br>.

Comment 6

[Joe Francis]

Attachment: patch to editor/libeditor/html/nsHTMLEditRules.{h,cpp}

added link splitting to WillInsertBreak().  Also factored out a blob of code
which may need other callers someday.

Comment 7

[Joe Francis]

cc'ing kin for sr love

Comment 8

[Joe Francis]

changing product

Comment 9

[kinmoz]

Comment on attachment 105753 [details] [diff] [review]
patch to editor/libeditor/html/nsHTMLEditRules.{h,cpp}

sr=[e-mail]

==== Fix indentation:


+    res = ReturnStandardImpl(node, offset, aSelection);
+	  *aHandled = PR_TRUE;


==== Fix the indentation of everything in |ReturnStandardImpl()| and lose the
tabs.

==== |ReturnStandardImpl()| sounds funny to me ... but maybe it's just me. I
kind of like |StandardBreakImpl()|.

Comment 10

[Kathleen :Brade]

Comment on attachment 105753 [details] [diff] [review]
patch to editor/libeditor/html/nsHTMLEditRules.{h,cpp}

r=brade with above changes (I also prefer StandardBreakImpl if it matters).

Comment 11

[Joe Francis]

fix landed on trunk

Comment 12

[rubydoo123]

tested using build from 20030407 on win2K, dropping in a link and hitting return
to continue writing does indeed terminate the link.