1721474 - The new redesigned Clear recent history window modal could use sentence casing

Status: VERIFIED FIXED

(Toolkit Graveyard :: Notifications and Alerts, enhancement)

Description

[kanapa1]

Attachment: Clear_recent_history_uses_title_casing.png

Currently, the Clear recent history window modal uses title casing for its various checkbox captions (see attached screenshot).

Since this window modal is now being redesigned for Proton, I think it may be a good idea to change the capitalization to sentence casing to match the new Proton conventions.

Comment 1

[:Gijs (he/him)]

Attachment: Bug 1721474 - use sentence case in the clear recent history dialog, r?mconley

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/18fc1360f9ca
use sentence case in the clear recent history dialog, r=mconley,fluent-reviewers,flod

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/18fc1360f9ca

Comment 4

[Ciprian Georgiu, Desktop QA]

We can confirm that the checkboxes' strings are correctly sentence cased in the Clear recent history window modal, using latest Nightly 93.0a1. Tested with Win 10 x64, macOS 11 and Ubuntu 21.04 x64.

I think this may be expected since I cannot see any details referring to the modal window title; The "Clear Recent History" appear capitalized. Is this something intended, Gijs?

Comment 5

[:Gijs (he/him)]

(In reply to Ciprian Georgiu [:ciprian_georgiu], Release Desktop QA from comment #4)

We can confirm that the checkboxes' strings are correctly sentence cased in the Clear recent history window modal, using latest Nightly 93.0a1. Tested with Win 10 x64, macOS 11 and Ubuntu 21.04 x64.

I think this may be expected since I cannot see any details referring to the modal window title; The "Clear Recent History" appear capitalized. Is this something intended, Gijs?

Based on e.g. the close tabs warning which uses sentence case, I suspect the title should also be fixed to be sentence case. Can you file a follow-up bug?

Comment 6

[Ciprian Georgiu, Desktop QA]

(In reply to :Gijs (out; back Aug 31st; he/him) from comment #5)

Based on e.g. the close tabs warning which uses sentence case, I suspect the title should also be fixed to be sentence case. Can you file a follow-up bug?

Thanks! I've filed it in bug 1727912.

Comment 7

[Ciprian Georgiu, Desktop QA]

Closing this as verified fixed per comment 4, since we've filed a follow up bug for the remaining issue.