1721476 - sqlite 3.34 changed it's open semantics, causing nss failures.

Status: RESOLVED FIXED

(NSS :: Libraries, defect)

Description

[Robert Relyea]

Attachment: nss-sqlite-readwrite-fix.patch

https://sqlite.org/forum/info/42cf8e985bb051a2

sqlite is now permissive on opening a readonly file even if you ask for the file to be opened R/W.

normally sqlite is very conservative in changing it's underlying semantics, but evidently they chose convience over compatibility. NSS now needs to check the file permissions itself to preserve nss semantics.

The attached patch is for reference I'll attach a phabricator version for review.

Comment 1

[Robert Relyea]

This should be the last of the rebase patches. I missed this one originally because it was only in fedora and rhel-9. It's not critical until more people start using nss with sqlite 3.44.

Comment 2

[Robert Relyea]

Attachment: Bug 1721476 sqlite 3.34 changed it's open semantics, causing nss failures.

https://sqlite.org/forum/info/42cf8e985bb051a2

sqlite is now permissive on opening a readonly file even if you ask for the file to be opened R/W.

normally sqlite is very conservative in changing it's underlying semantics, but evidently they chose convience over compatibility. NSS now needs to check the file permissions itself to preserve nss semantics.

Comment 3

[Benjamin Beurdouche [:beurdouche]]

https://hg.mozilla.org/projects/nss/rev/f2d34a957599067e31bc035ed5df357c620fc035

Comment 4

[Stanislav Levin]

Same issue:
https://bugzilla.mozilla.org/show_bug.cgi?id=1690232