Closed Bug 1721509 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 29724 - [LayoutNG] OOF inline offset with inline containing block

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
92 Branch
Tracking Flags:
Tracking Status
firefox92 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29724 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29724
Details from upstream follow.

b'Alison Maher <almaher@microsoft.com>' wrote:

[LayoutNG] OOF inline offset with inline containing block

When computing the inline containing block geometry in
ComputeInlineContainerGeometryForFragmentainer(), we had originally
calculated the offsets so that they were relative to the top of the
fragmentation context root. However, we weren't taking the inline
offset of the containing block into account, which can lead to
the wrong OOF offset.

Instead, calculate the offsets so that they are relative to the
containing block and add the offset of the containing block relative
to the fragmentation context root during the final inline CB rect
offset calculation. This ensures that we are also adding in the
inline offset from the containing block.

This update also resulted in a simplification of the number of input
variables and calculations previously needed in
ComputeInlineContainerGeometryForFragmentainer().

Bug: 1231218
Change-Id: I6d5bd2bffab0fde0a7b29b405494b33273eba2f6

Reviewed-on: https://chromium-review.googlesource.com/3042100
WPT-Export-Revision: 9142908ad34092f83ec89a1e64591212740185e4

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

FAIL: 1

Chrome

PASS: 1

Safari

FAIL: 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-break/out-of-flow-in-multicolumn-068.html: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/439f14232adc
[wpt PR 29724] - [LayoutNG] OOF inline offset with inline containing block, a=testonly
https://hg.mozilla.org/integration/autoland/rev/72b59a341b62
[wpt PR 29724] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ea180423f5bd
[wpt PR 29724] - [LayoutNG] OOF inline offset with inline containing block, a=testonly
https://hg.mozilla.org/integration/autoland/rev/3470a54cb6cf
[wpt PR 29724] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/ea180423f5bd
https://hg.mozilla.org/mozilla-central/rev/3470a54cb6cf

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox92: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
You need to log in before you can comment on or make changes to this bug.