Closed Bug 1721514 Opened 3 years ago Closed 3 years ago

Use bootstrapped sysroot when it's there

Categories

(Firefox Build System :: Bootstrap Configuration, task)

task

Tracking

(firefox92 fixed)

RESOLVED FIXED
92 Branch
Tracking Status
firefox92 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

No description provided.

We do that with everything else (i.e. clang, cbindgen, etc.). We weren't
doing it for sysroots because the support was experimental and the path
was independent of the target, so there was no guarantee that the
sysroot would actually work for the target. As that's not the case
anymore, we can go with more consistency with the bootstrapped
toolchains.

Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/1b2d14cf3154 Add a few more debugging logs about configure bootstrap. r=firefox-build-system-reviewers,andi https://hg.mozilla.org/integration/autoland/rev/36a5d8e7d4eb Use bootstrapped sysroot when it's there. r=firefox-build-system-reviewers,andi
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch

hey there, gentoo user here.

it seems as if the recent changes in this bug are problematic, since the config scripts automatically use the --sysroot switch to check for bindgen cflags:

0:26.28 checking bindgen cflags... -x c++ -fno-sized-deallocation -fno-aligned-new -DTRACING=1 -DIMPL_LIBXUL -DMOZILLA_INTERNAL_API -DRUST_BINDGEN -DOS_POSIX=1 -DOS_LINUX=1 --sysroot /usr/aarch64-unknown-linux-gnu -std=gnu++17 --target=aarch64-linux-gnu
0:26.29 ERROR: --with-system-ffi is not supported with bootstrapped sysroot. Drop the option, or use --without-sysroot or --disable-bootstrap
Error running mach:

['configure']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.
You can invoke |./mach busted| to check if this issue is already on file. If it
isn't, please use |./mach busted file configure| to report it. If |./mach busted| is
misbehaving, you can also inspect the dependencies of bug 1543241.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

Exception: Process executed with non-0 exit code 1: ['/usr/bin/python3.9', '/usr/aarch64-unknown-linux-gnu/tmp/portage/www-client/firefox-92.0-r1/work/firefox-92.0/configure.py']

File "/usr/aarch64-unknown-linux-gnu/tmp/portage/www-client/firefox-92.0-r1/work/firefox-92.0/python/mozbuild/mozbuild/build_commands.py", line 185, in configure
return driver.configure(
File "/usr/aarch64-unknown-linux-gnu/tmp/portage/www-client/firefox-92.0-r1/work/firefox-92.0/python/mozbuild/mozbuild/controller/building.py", line 1528, in configure
status = self._run_command_in_objdir(
File "/usr/aarch64-unknown-linux-gnu/tmp/portage/www-client/firefox-92.0-r1/work/firefox-92.0/python/mozbuild/mozbuild/base.py", line 845, in _run_command_in_objdir
return self.run_process(cwd=self.topobjdir, **args)
File "/usr/aarch64-unknown-linux-gnu/tmp/portage/www-client/firefox-92.0-r1/work/firefox-92.0/python/mach/mach/mixin/process.py", line 174, in run_process
raise Exception(

  • ERROR: www-client/firefox-92.0-r1::gentoo failed (configure phase):

The source code is a snapshot from today, with your changes merged.

If I pass --disable-bootstrap, the error message doesn't change.

Can you maybe improve the error message a bit, it seems to give somehow outdated advice?

Flags: needinfo?(mh+mozilla)
Regressions: 1722442
Flags: needinfo?(mh+mozilla)
Regressions: 1723956
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: