Closed Bug 1721529 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 29725 - [fsa] Implement flush for the sync access handle

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox92 fixed)

Status:
RESOLVED FIXED
Milestone:
92 Branch
Tracking Flags:
Tracking Status
firefox92 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29725 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29725
Details from upstream follow.

b'Andreas Haas <ahaas@chromium.org>' wrote:

[fsa] Implement flush for the sync access handle

The implementation is ported from the implementation of
Storage Foundation in
https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/native_io/native_io_file_async.cc.

This is part of the efforts to merge Storage Foundation into OPFS.

Bug: chromium:1218431
Change-Id: I51b7def56a51af5c1ef384dce5c982604a48496d
Reviewed-on: https://chromium-review.googlesource.com/3030342
WPT-Export-Revision: ced750415d7ea121f5e35661a633f0769d56113d

PR 29725 applied with additional changes from upstream: 03d01f21e8fa92829c2c027b85f45ffb24cc4992

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 7 subtests

Status Summary

Firefox

OK : 2
FAIL: 11

Chrome

OK : 2
FAIL: 11

Safari

OK : 2
FAIL: 11

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/file-system-access/sandboxed_FileSystemSyncAccessHandle-flush.https.tentative.worker.html
Test flush on an empty file.: FAIL (Chrome: FAIL, Safari: FAIL)
SyncAccessHandle.read returns bytes written by SyncAccessHandle.write after SyncAccessHandle.flush: FAIL (Chrome: FAIL, Safari: FAIL)
SyncAccessHandle.read fails when there is a pending SyncAccessHandle.flush: FAIL (Chrome: FAIL, Safari: FAIL)
SyncAccessHandle.write fails when there is a pending SyncAccessHandle.flush: FAIL (Chrome: FAIL, Safari: FAIL)
/file-system-access/sandboxed_FileSystemSyncAccessHandle-read-write.https.tentative.worker.html
Test reading an empty file through a sync access handle.: FAIL (Chrome: FAIL, Safari: FAIL)
Test writing and reading through a sync access handle.: FAIL (Chrome: FAIL, Safari: FAIL)
Test second write that is bigger than the first write: FAIL (Chrome: FAIL, Safari: FAIL)
Test second write that is smaller than the first write: FAIL (Chrome: FAIL, Safari: FAIL)
Test initial write with an offset: FAIL (Chrome: FAIL, Safari: FAIL)
Test overwriting the file at an offset: FAIL (Chrome: FAIL, Safari: FAIL)
Test read at an offset: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e50acbcc6dc7 [wpt PR 29725] - [fsa] Implement flush for the sync access handle, a=testonly https://hg.mozilla.org/integration/autoland/rev/1c95d98d901a [wpt PR 29725] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/e50acbcc6dc7
https://hg.mozilla.org/mozilla-central/rev/1c95d98d901a

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox92: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
You need to log in before you can comment on or make changes to this bug.