Closed Bug 1721531 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 29726 - [fsa] Implement close for the sync access handle

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox92 fixed)

RESOLVED FIXED
92 Branch
Tracking Status
firefox92 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29726 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29726
Details from upstream follow.

b'Andreas Haas <ahaas@chromium.org>' wrote:

[fsa] Implement close for the sync access handle

The implementation is ported from the implementation of
Storage Foundation in
https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/native_io/native_io_file_async.cc.

This is part of the efforts to merge Storage Foundation into OPFS.

Bug: chromium:1218431
Change-Id: I03e0a3027b2ace8d07b04d9b8c5e2fb9fdcee454
Reviewed-on: https://chromium-review.googlesource.com/3035097
WPT-Export-Revision: 09cc982560cac07041d9637c110f5432f62ada1e

PR 29726 applied with additional changes from upstream: 03d01f21e8fa92829c2c027b85f45ffb24cc4992

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests and 4 subtests

Status Summary

Firefox

OK : 2[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-opt-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-tsan-opt, Gecko-windows10-32-qr-debug, Gecko-windows10-64-qr-debug] 3[GitHub]
FAIL: 15[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-opt-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-tsan-opt, Gecko-windows10-32-qr-debug, Gecko-windows10-64-qr-debug] 19[GitHub]

Chrome

OK : 3
FAIL: 19

Safari

OK : 3
FAIL: 19

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/file-system-access/sandboxed_FileSystemSyncAccessHandle-close.https.tentative.worker.html
SyncAccessHandle.close is idempotent: FAIL (Chrome: FAIL, Safari: FAIL)
SyncAccessHandle.close is idempotent when called immediately: FAIL (Chrome: FAIL, Safari: FAIL)
SyncAccessHandle.read fails after SyncAccessHandle.close settles: FAIL (Chrome: FAIL, Safari: FAIL)
SyncAccessHandle.read fails immediately after calling SyncAccessHandle.close: FAIL (Chrome: FAIL, Safari: FAIL)
SyncAccessHandle.write fails after SyncAccessHandle.close settles: FAIL (Chrome: FAIL, Safari: FAIL)
SyncAccessHandle.write fails immediately after calling SyncAccessHandle.close: FAIL (Chrome: FAIL, Safari: FAIL)
SyncAccessHandle.flush fails after SyncAccessHandle.close settles: FAIL (Chrome: FAIL, Safari: FAIL)
SyncAccessHandle.flush fails immediately after calling SyncAccessHandle.close: FAIL (Chrome: FAIL, Safari: FAIL)
/file-system-access/sandboxed_FileSystemSyncAccessHandle-read-write.https.tentative.worker.html
Test reading an empty file through a sync access handle.: FAIL (Chrome: FAIL, Safari: FAIL)
Test writing and reading through a sync access handle.: FAIL (Chrome: FAIL, Safari: FAIL)
Test second write that is bigger than the first write: FAIL (Chrome: FAIL, Safari: FAIL)
Test second write that is smaller than the first write: FAIL (Chrome: FAIL, Safari: FAIL)
Test initial write with an offset: FAIL (Chrome: FAIL, Safari: FAIL)
Test overwriting the file at an offset: FAIL (Chrome: FAIL, Safari: FAIL)
Test read at an offset: FAIL (Chrome: FAIL, Safari: FAIL)
/file-system-access/sandboxed_FileSystemSyncAccessHandle-flush.https.tentative.worker.html
Test flush on an empty file.: FAIL (Chrome: FAIL, Safari: FAIL)
SyncAccessHandle.read returns bytes written by SyncAccessHandle.write after SyncAccessHandle.flush: FAIL (Chrome: FAIL, Safari: FAIL)
SyncAccessHandle.read fails when there is a pending SyncAccessHandle.flush: FAIL (Chrome: FAIL, Safari: FAIL)
SyncAccessHandle.write fails when there is a pending SyncAccessHandle.flush: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2a0629206548 [wpt PR 29726] - [fsa] Implement close for the sync access handle, a=testonly https://hg.mozilla.org/integration/autoland/rev/4063787d22d2 [wpt PR 29726] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
You need to log in before you can comment on or make changes to this bug.