1721571 - Remove ResponsiveActor (get|set|clear)MetaViewportOverride

Status: RESOLVED FIXED

(DevTools :: Responsive Design Mode, task)

Description

[Nicolas Chevobbe [:nchevobbe]]

The functions are only called from updateTouchSimulation (devtools/client/responsive/ui.js#887-894) and they're always called before the call to updateConfiguration for touch simulation, based on the touch simulation value.
This means we can directly set the proper flag on the docShell in BrowsingContextTargetActor#updateTargetConfiguration before handling touch simulation.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1721571 - [devtools] Remove ResponsiveActor (get|set|clear)MetaViewportOverride. r=ochameau.

The functions were only called from RDM ui updateTouchSimulation, before
the call to updateConfiguration for touch simulation, based on the touch simulation value.
This means we can directly set the proper flag on the docShell in
BrowsingContextTargetActor#updateTargetConfiguration before handling touch simulation.

The devtools.responsive.metaViewport.enabled pref is removed, as it was set to
true by default, and wasn't exposed in any UI.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6218cc162c20
[devtools] Remove ResponsiveActor (get|set|clear)MetaViewportOverride. r=ochameau,devtools-backward-compat-reviewers.

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/6218cc162c20