Closed Bug 1721623 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 29733 - Revert "[BreakoutBox] Remove control signals"

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox92 fixed)

RESOLVED FIXED
92 Branch
Tracking Status
firefox92 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29733 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29733
Details from upstream follow.

b'Omar Morsi <omorsi@google.com>' wrote:

Revert "[BreakoutBox] Remove control signals"

This reverts commit d3e3ffc0b381bf75918602d95a1fbf300b0b3cd2.

Reason for revert: win-archive-rel build is failing in compile step with error clang-cl: error: no such file or directory: ‘gen/third_party/blink/renderer/bindings/modules/v8/v8_media_stream_track_signal.cc’ and this CL deletes a file with a similar name.
failing bots:

[BreakoutBox] Remove control signals

Bug: 1231028
Change-Id: I9047003c75fdc3f7ca8042917057c8d0ed97b1e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3039183
Commit-Queue: Tony Herre \<toprice@chromium.org>
Auto-Submit: Guido Urdaneta \<guidou@chromium.org>
Reviewed-by: Tony Herre \<toprice@chromium.org>
Cr-Commit-Position: refs/heads/master@{#903828}

Bug: 1231028
Change-Id: If475d3554aa38ee66e3761621779e60208482e5b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3041475
Reviewed-by: Alexander Hendrich \<hendrich@chromium.org>
Commit-Queue: Alexander Hendrich \<hendrich@chromium.org>
Auto-Submit: Omar Morsi \<omorsi@google.com>
Owners-Override: Omar Morsi \<omorsi@google.com>
Cr-Commit-Position: refs/heads/master@{#903840}

PR 29733 applied with additional changes from upstream: 88fb30ca01beab01356cf09e10b55830f02eb4da, 3ab765d7efc2e3c0252f61cfb4f8eb429cbed9ae

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 7 subtests

Status Summary

Firefox

OK : 2
FAIL: 15

Chrome

OK : 2
PASS: 10
FAIL: 5

Safari

OK : 2
FAIL: 15

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/mediacapture-insertable-streams/MediaStreamTrackGenerator-audio.https.html
Tests that creating a Audio MediaStreamTrackGenerator works as expected: FAIL (Chrome: FAIL, Safari: FAIL)
Tests that creating an Audio MediaStreamTrackGenerator with a signal target works as expected: FAIL (Chrome: FAIL, Safari: FAIL)
Creating Generator with an invalid kind throws: FAIL (Chrome: PASS, Safari: FAIL)
Creating Generator with a missing kind throws: FAIL (Chrome: PASS, Safari: FAIL)
Creating Generator with mismatched kinds throws: FAIL (Chrome: PASS, Safari: FAIL)
Creating Generator with invalid signalTarget throws: FAIL (Chrome: PASS, Safari: FAIL)
Mismatched data and generator kind throws on write.: FAIL (Chrome: FAIL, Safari: FAIL)
Tests that audio actually flows to a connected audio element: FAIL (Chrome: FAIL, Safari: FAIL)
/mediacapture-insertable-streams/MediaStreamTrackGenerator-video.https.html
Tests that MediaStreamTrackGenerator forwards frames to sink: FAIL (Chrome: PASS, Safari: FAIL)
Tests that frames are actually rendered correctly in a stream used for a video element.: FAIL (Chrome: PASS, Safari: FAIL)
Tests that frames are actually rendered correctly in a stream sent over a peer connection.: FAIL (Chrome: FAIL, Safari: FAIL)
Tests that creating a Video MediaStreamTrackGenerator works as expected: FAIL (Chrome: PASS, Safari: FAIL)
Tests that VideoFrames are destroyed on write.: FAIL (Chrome: PASS, Safari: FAIL)
Tests that creating a Video MediaStreamTrackGenerator with a signal target works as expected: FAIL (Chrome: PASS, Safari: FAIL)
Mismatched frame and generator kind throws on write.: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fb351f388ccd [wpt PR 29733] - Revert "[BreakoutBox] Remove control signals", a=testonly
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
You need to log in before you can comment on or make changes to this bug.