Closed Bug 1721673 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 29739 - [GridNG] Re-compute grid with a forced initial block-size indefinite.

Categories

(Core :: Layout: Grid, task, P4)

Product:
Core
Component:
Layout: Grid
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
92 Branch
Tracking Flags:
Tracking Status
firefox92 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29739 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29739
Details from upstream follow.

b'Ian Kilpatrick <ikilpatrick@chromium.org>' wrote:

[GridNG] Re-compute grid with a forced initial block-size indefinite.

Flexbox is able to force an item (the grid in this case) to have an
indefinite initial block-size. (See testcase for exact scenario).

Grid will typically re-compute the grid with the final used block-size.
The current behaviour might have a grid sized at 100px, but a single
auto track sized at 0px.

The complexity here is that we can't ignore indefinite initial
block-size as we need to compute the IntrinsicBlockSize correctly, as
flexbox will use this value in its algorithm.

The fix is to check when we have this flag set, and if this block-size
is definite (ignoring this flag) re-compute the grid in the outer
2nd-pass.

Bug: 1055258
Change-Id: I469ecc26c32ddc13a7285b8cb749eef17a317ec9

Reviewed-on: https://chromium-review.googlesource.com/2994864
WPT-Export-Revision: f21240e49783702046fde96c6acea8e5099a945f

Component: web-platform-tests → Layout: Grid
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

FAIL: 1

Safari

FAIL: 1

Links

GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/502066ccee5b
[wpt PR 29739] - [GridNG] Re-compute grid with a forced initial block-size indefinite., a=testonly

https://hg.mozilla.org/mozilla-central/rev/502066ccee5b

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox92: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
You need to log in before you can comment on or make changes to this bug.