1721686 - Improve the intrinsics framework

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, task, P2)

Description

[Ryan Hunt [:rhunt]]

• Support multiple intrinsics in a module
• Support shared memory
• Expose mozIntGemm() on WebAssembly when in privileged content
• Add tests to ensure we don't expose this unwittingly to web content

Comment 1

[Ryan Hunt [:rhunt]]

Attachment: Bug 1721686 - wasm: Allow multiple intrinsics in an intrinsics module. r?yury

Comment 2

[Ryan Hunt [:rhunt]]

Attachment: Bug 1721686 - wasm: Allow requiring shared memory for an intrinsics module. r?yury

Depends on D120660

Comment 3

[Ryan Hunt [:rhunt]]

Attachment: Bug 1721686 - wasm: Add mozIntGemm() to WebAssembly namespace in privileged content. r?yury

Depends on D120661

Comment 4

[Yury Delendik (:yury)]

Attachment: Bug 1721686 - wasm: Generate intrinsics boilerplate code via yaml. r?rhunt

Comment 5

[Ryan Hunt [:rhunt]]

Attachment: Bug 1721686 - wasm: Define exception handling constructors only if runtime enabled. r?yury

Before this commit we would unconditionally define the constructors for
exception handling objects on the wasm namespace if the feature was
compile-time enabled. We should further restrict this to only
enable the feature if the runtime flag is also enabled.

Depends on D120662

Comment 6

[Ryan Hunt [:rhunt]]

Attachment: Bug 1721686 - Add test for exposed interfaces on WebAssembly namespace. r?smaug

This commit modifies test_interfaces.js to also test the exposed interfaces
in the WebAssembly namespace. We have conditional features that we'd like
to have confidence that we're not accidentally exposing to web content.

Currently there are:

• WebAssembly exceptions, enabled only in nightly with a default-off pref
• mozIntGemm accelerator function, available only in system or addon principals

Depends on D120731

Comment 7

[Ryan Hunt [:rhunt]]

Landing everything but the final test as I've verified that it passes and don't want to block the result of this work.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7bbc69180316
wasm: Allow multiple intrinsics in an intrinsics module. r=yury
https://hg.mozilla.org/integration/autoland/rev/226e4f35aa52
wasm: Allow requiring shared memory for an intrinsics module. r=yury
https://hg.mozilla.org/integration/autoland/rev/7ff074e3a920
wasm: Add mozIntGemm() to WebAssembly namespace in privileged content. r=yury
https://hg.mozilla.org/integration/autoland/rev/248879341368
wasm: Define exception handling constructors only if runtime enabled. r=yury

Comment 9

[Cosmin Sabou [:CosminS]]

Backed out for wasm related spidermonkey failures.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cusercancel&revision=2488793413684541b21776ed569327f950041e20&selectedTaskRun=QKbDQB27Rj6AmZlvXW5eQQ.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=346911435&repo=autoland
https://treeherder.mozilla.org/logviewer?job_id=346911398&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/f77a1e5a83a75069060ac3d60793381bd76eac16

Comment 10

[Ryan Hunt [:rhunt]]

One of the commits changed the expected test results for wasm exception-handling WPT's. Updated patches update the expectations.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/55cc3ae54759
wasm: Allow multiple intrinsics in an intrinsics module. r=yury
https://hg.mozilla.org/integration/autoland/rev/b24f7485b46c
wasm: Allow requiring shared memory for an intrinsics module. r=yury
https://hg.mozilla.org/integration/autoland/rev/c4541cb343ae
wasm: Add mozIntGemm() to WebAssembly namespace in privileged content. r=yury
https://hg.mozilla.org/integration/autoland/rev/a00942e4cb52
wasm: Define exception handling constructors only if runtime enabled. r=yury

Comment 12

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/55cc3ae54759
https://hg.mozilla.org/mozilla-central/rev/b24f7485b46c
https://hg.mozilla.org/mozilla-central/rev/c4541cb343ae
https://hg.mozilla.org/mozilla-central/rev/a00942e4cb52

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/010ddecfd41c
wasm: Generate intrinsics boilerplate code via yaml. r=rhunt

Comment 14

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/010ddecfd41c

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/482ce06ec0d2
Add test for exposed interfaces on WebAssembly namespace. r=smaug

Comment 16

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/482ce06ec0d2